Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add smart_rule and integrate with shell_logger #790

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

sameetandpotatoes
Copy link

@sameetandpotatoes sameetandpotatoes commented Feb 26, 2018

  • Adds a smart rule that looks at previous user corrections of incorrect commands to suggest those fixes again.
  • As of now, the priority is set to 10000 on the new smart_rule.
  • Queries a key-value store in shell_logger for frequent, corrected commands.
  • Enabled with:
eval "$(thefuck --enable-experimental-shell-history)"

I'd like some feedback on our current implementation.

shell_logger PR: nvbn/shell_logger#2

What needs to be done:

  • Merge and release shell_logger PR
  • Fix first time setup so that we don't download shell_logger every time the terminal is reloaded.
  • Implement smart detection of versioning of shell_logger so that the download is started automatically when shell_logger is updated. Or, figure out a better way to bundle shell_logger with thefuck.
  • Determine why ./shell_logger -mode daemon returns a new line so that eval hangs (the fix was to redirect stdout, but that seems more like a hack)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants