Fix prevent display from turning off

[LeonarddeR]

Link to issue number:

Fixes #17705 
Fixup of #17651

Summary of the issue:

Pr #17651 introduced a feature flag in the general section of the config, but this is not supported yet.

Description of user facing changes

General settings panel can be reopened after saving.

Description of development approach

Rename the flag and make it a boolean.

Testing strategy:

Tested str from #17705 

Known issues with pull request:

I had to rename the config setting because otherwise, configuration would get corrupted on Alpha.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

@coderabbitai summary

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: License check.
• PASS: Unit tests.
• PASS: Lint check.
• Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 8dc7a35975

[CyrilleB79]

@LeonarddeR, you write:

Pr #17651 introduced a feature flag in the general section of the config, but this is not supported yet.

I guess that this limitation is not logged in a GitHub issue.
Could you open one describing the issue in details? As well as information that you may have already gathered while on this issue investigating #17705. More specifically I wonder, if you have figured it, if the limitation applies to the general section of the config or the General panel in the settings dialog.

[LeonarddeR]

@CyrilleB79 I'm not sure. While this is in fact a shortcoming in the current implementation of feature flags, until now there hasn't been a desire to have a feature flag in the general section, and neither we know whether that desire will ever come back. It feels a bit unnecessary to open an issue that describes a problem that only arises in a certain situation.

[CyrilleB79]

OK let's wait and see if NV Access is happy to have a checkbox instead of a feature flag for this feature.

Anyway, could you please write here the results of your investigation on the existing limitation with feature flags in General panel or general config section?

[LeonarddeR]

As far as I understand it correctly, all sections that are not part of config.conf.BASE_ONLY_SECTIONS will create an AggregatedSection object in the config manager. This class has logic to account for feature flag, i.e. when setting a value to a feature flag, the value is instantly validated. This doesn't apply to the base only sections, that are just configOBj.Section objects.

[SaschaCowley]

@LeonarddeR can you please open an issue for the fact that any section in ConfigManager.BASE_ONLY_SECTIONS cannot have a config flag? The issue here is wider than just general settings

[LeonarddeR]

I opened #17723

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: License check.
• PASS: Unit tests.
• PASS: Lint check.
• Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit ead5c96a15