Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nltk.bigrams & remove nltk dependency alert #80

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix nltk.bigrams & remove nltk dependency alert #80

merged 2 commits into from
Jul 2, 2024

Conversation

tzemicheal
Copy link
Contributor

Description

Remove ntlk dependency triggering https://github.com/nv-morpheus/morpheus-experimental/security/dependabot/154

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@tzemicheal tzemicheal added the improvement Improvement to existing functionality label Jul 1, 2024
@tzemicheal tzemicheal self-assigned this Jul 1, 2024
@tzemicheal tzemicheal requested a review from a team as a code owner July 1, 2024 21:14
@tzemicheal tzemicheal added the non-breaking Non-breaking change label Jul 1, 2024
raykallen
raykallen approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@raykallen raykallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tzemicheal tzemicheal merged commit b3b767f into nv-morpheus:branch-24.06 Jul 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raykallen raykallen raykallen approved these changes

Assignees

@tzemicheal tzemicheal

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzemicheal @raykallen