Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the python package files #98

Merged
15 commits merged into from
May 13, 2022

Conversation

mdemoret-nv
Copy link
Contributor

@mdemoret-nv mdemoret-nv commented May 10, 2022

This refactors all of the python package files to improve the directory structure, separate classes into their own files, improve readability and reduce merge conflicts. The main morpheus package will now be subdivided into the following submodules:

morpheus/
   _lib/
   io/
   messages/
   pipelines/
   stages/
      general/
      inference/
      input/
      output/
      postprocess/
      preprocess
   utils/

The largest differences are coming from separating the morpheus/pipeline.py into separate files and breaking all stages into their own package (resulting in quite a few new files).

Remaining questions:

  • How to handle package reloads for morpheus.messages
  • What to call utilities? utils? or utilities?

Closes #98

@mdemoret-nv mdemoret-nv added enhancement Additional functionality added to an existing feature breaking Breaking change labels May 10, 2022
@mdemoret-nv mdemoret-nv added feature request New feature or request and removed enhancement Additional functionality added to an existing feature labels May 10, 2022
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Really makes things easier to digest. Good set of changes.

@dagardner-nv dagardner-nv self-requested a review May 12, 2022 19:04
@mdemoret-nv
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit 6b56c9a into nv-morpheus:branch-22.06 May 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants