-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize the python package files #98
Merged
15 commits merged into
nv-morpheus:branch-22.06
from
mdemoret-nv:mdd_reorg-python-files
May 13, 2022
Merged
Reorganize the python package files #98
15 commits merged into
nv-morpheus:branch-22.06
from
mdemoret-nv:mdd_reorg-python-files
May 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
added
enhancement
Additional functionality added to an existing feature
breaking
Breaking change
labels
May 10, 2022
mdemoret-nv
added
feature request
New feature or request
and removed
enhancement
Additional functionality added to an existing feature
labels
May 10, 2022
mdemoret-nv
requested review from
BartleyR,
pdmack,
bsuryadevara,
dagardner-nv,
drobison00,
efajardo-nv,
cwharris and
raykallen
as code owners
May 11, 2022 02:07
dagardner-nv
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
drobison00
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- Really makes things easier to digest. Good set of changes.
dagardner-nv
approved these changes
May 12, 2022
BartleyR
approved these changes
May 13, 2022
@gpucibot merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors all of the python package files to improve the directory structure, separate classes into their own files, improve readability and reduce merge conflicts. The main morpheus package will now be subdivided into the following submodules:
The largest differences are coming from separating the
morpheus/pipeline.py
into separate files and breaking all stages into their own package (resulting in quite a few new files).Remaining questions:
morpheus.messages
utils
? orutilities
?Closes #98