-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to developer_guide for clarity. #96
Conversation
@dagardner-nv Can you please review these documentation changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made a few corrections and comments to aid in review.
(if preferred, I can also bundle up all of the comment suggestions and squash them into the original commit, rebase, and force push to my branch so the PR will just be one commit with everything) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @lobotmcj
@dagardner-nv thank you for reviewing. Apparently GitHub adds one additional commit per accepted suggestion in the PR review process. This is going to make for a lot of commits. But it will be fine -- to keep things clean, once the review is all done and all the commits are added, I will rebase and squash so that it's just one linear commit to the Morpheus git history. Let me know if this is acceptable to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if this blasted you with notifications, still getting used to how GitHub does this vice GitLab.
@lobotmcj don't worry about rebasing and squashing I believe that is something that we do on merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consistently using unhyphenated "pass through" in all sentences per request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x2 "pass through" instead of "pass-through" changes.
LGTM, thanks |
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
Co-authored-by: Jeffrey James <lobotmcj@gmail.com>
@pdmack let me know if you also want to squash the commits together; I'm fine either way |
@gpucibot merge |
Closes #95