Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix_contrib_instructions #959

Merged
merged 1 commit into from
May 31, 2023
Merged

fix_contrib_instructions #959

merged 1 commit into from
May 31, 2023

Conversation

yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented May 31, 2023 •
edited
Loading

Description

Fix contributing.md - adding a step to fetch data sets before running pytest.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@yczhang-nv yczhang-nv requested a review from a team as a code owner May 31, 2023 20:54
@rapids-bot
Copy link

rapids-bot bot commented May 31, 2023

Pull requests from external contributors require approval from a nv-morpheus organization member with write or admin permissions before CI can begin.

@yczhang-nv yczhang-nv closed this May 31, 2023
@yczhang-nv yczhang-nv reopened this May 31, 2023
@yczhang-nv yczhang-nv marked this pull request as draft May 31, 2023 21:54
@yczhang-nv yczhang-nv marked this pull request as ready for review May 31, 2023 22:02
@drobison00 drobison00 added enhancement Additional functionality added to an existing feature non-breaking Non-breaking change improvement Improvement to existing functionality 5 - Ready to Merge labels May 31, 2023
@drobison00
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 453ce58 into nv-morpheus:branch-23.07 May 31, 2023
@yczhang-nv yczhang-nv deleted the yuchen_fix_contrib_instructions branch September 16, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

Assignees
No one assigned
Labels
enhancement Additional functionality added to an existing feature improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yczhang-nv @drobison00