Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated usage of make_node and make_node_full #839

Merged
merged 15 commits into from
Apr 13, 2023
Merged

Replace deprecated usage of make_node and make_node_full #839

merged 15 commits into from
Apr 13, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Apr 3, 2023 •
edited
Loading

Description

  • make_node_full has been deprecated in MRC as has passing an on-next method directly to make_node
  • Removed a few debug warnings from examples

fixes #782

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality 2 - In Progress labels Apr 3, 2023
@dagardner-nv dagardner-nv requested review from a team as code owners April 3, 2023 18:17
mdemoret-nv
mdemoret-nv approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. The code is much cleaner without the extra layer of build functions.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 93b81c1 into nv-morpheus:branch-23.07 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Update all uses of deprecated make_node and make_node_full functions
2 participants
@dagardner-nv @mdemoret-nv