Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clang-format on entire repo #719

Merged
merged 5 commits into from
Feb 23, 2023

Conversation

efajardo-nv
Copy link
Contributor

Closes #713

@efajardo-nv efajardo-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Feb 17, 2023
@efajardo-nv efajardo-nv requested a review from a team as a code owner February 17, 2023 20:09
@efajardo-nv efajardo-nv marked this pull request as draft February 17, 2023 21:55
@efajardo-nv efajardo-nv marked this pull request as ready for review February 17, 2023 23:51
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this.

@mdemoret-nv mdemoret-nv requested a review from a team as a code owner February 23, 2023 00:27
@mdemoret-nv mdemoret-nv removed the request for review from a team February 23, 2023 00:35
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit b8671c6 into nv-morpheus:branch-23.03 Feb 23, 2023
rapids-bot bot pushed a commit that referenced this pull request Feb 24, 2023
- Updates the `fix_all.sh` script to take an optional `IGNORE_GIT_DIFF` environment variable
- This allows `fix_all.sh` to run on all files, not just changes in this PR. Use with `IGNORE_GIT_DIFF=1 ./ci/scripts/fix_all.sh`
- Updates the `copyright.py` to be better organized
- Updates `ci/scripts/common.sh` with updated path regexes
- Runs `fil_all.sh` on the repo and commited changes

Should go in after #719 
Related to #713
Closes #732

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)
  - Tad ZeMicheal (https://github.com/tzemicheal)
  - Christopher Harris (https://github.com/cwharris)

URL: #731
jjacobelli pushed a commit to jjacobelli/Morpheus that referenced this pull request Mar 7, 2023
jjacobelli pushed a commit to jjacobelli/Morpheus that referenced this pull request Mar 7, 2023
- Updates the `fix_all.sh` script to take an optional `IGNORE_GIT_DIFF` environment variable
- This allows `fix_all.sh` to run on all files, not just changes in this PR. Use with `IGNORE_GIT_DIFF=1 ./ci/scripts/fix_all.sh`
- Updates the `copyright.py` to be better organized
- Updates `ci/scripts/common.sh` with updated path regexes
- Runs `fil_all.sh` on the repo and commited changes

Should go in after nv-morpheus#719 
Related to nv-morpheus#713
Closes nv-morpheus#732

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)
  - Tad ZeMicheal (https://github.com/tzemicheal)
  - Christopher Harris (https://github.com/cwharris)

URL: nv-morpheus#731
@efajardo-nv efajardo-nv deleted the clang-formatting branch July 29, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Fix all formatting issues for 23.03
3 participants