Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub CLI support to devcontainer #629

Merged
4 commits merged into from
Jan 26, 2023
Merged

Add GitHub CLI support to devcontainer #629

4 commits merged into from
Jan 26, 2023

Conversation

cwharris
Copy link
Contributor

Closes #619

@cwharris cwharris added enhancement Additional functionality added to an existing feature non-breaking Non-breaking change labels Jan 24, 2023
@cwharris cwharris requested a review from a team as a code owner January 24, 2023 17:59
@cwharris cwharris added the feature request New feature or request label Jan 24, 2023
@cwharris
Copy link
Contributor Author

These changes cause a weird bug:

mkdir: cannot create directory ‘/home/coder/.config/vscode-dev-containers’: Permission denied
coder ➜ /workspaces/morpheus (devcontainer-gh-cli) $ touch: cannot touch '/home/coder/.config/vscode-dev-containers/first-run-notice-already-displayed': No such file or directory

It looks like the .config directory is owned by root and not coder (the host user), so scripts can't create directories there. Not sure how to work around this outside of mounting the entire .config directory, which seems undesirable.

@cwharris
Copy link
Contributor Author

@mdemoret-nv your changes look good to me.

mdemoret-nv
mdemoret-nv approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link
Contributor

/merge

@ghost ghost merged commit d2b947f into nv-morpheus:branch-23.01 Jan 26, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
enhancement Additional functionality added to an existing feature feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Install Github CLI in devcontainer
2 participants
@cwharris @mdemoret-nv