-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table locking & column preallocation #586
Merged
152 commits merged into
nv-morpheus:branch-23.03
from
dagardner-nv:david-mdd_table-info-locking
Feb 6, 2023
Merged
Table locking & column preallocation #586
152 commits merged into
nv-morpheus:branch-23.03
from
dagardner-nv:david-mdd_table-info-locking
Feb 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainst the classification labels
deserialize stage to slice up the input and trigger the bug
…us into david-add-scores-bug
…etection stage tests, also fix multi-segment tests
…de that is always bypassed
…v/Morpheus into david-mdd_table-info-locking
mdemoret-nv
previously approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but lets target this for 23.03
dagardner-nv
dismissed
mdemoret-nv’s stale review
January 31, 2023 16:23
The base branch was changed.
mdemoret-nv
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets get this in early in the cycle.
/merge |
jjacobelli
pushed a commit
to jjacobelli/Morpheus
that referenced
this pull request
Mar 7, 2023
* Builds on changes in nv-morpheus#427 * Adds a `PreallocatorMixin` which when added to a stage performs pre-allocation. This should be added to the first stage in a pipeline which emits a DataFrame or MessageMeta in a pipeline. * Morpheus' TypeId enum exposed to the Python API, allowing stages to define types for columns needing pre-allocation * `MutableTableInfo` exposed to Python via a context manager to be used in `with` blocks * `type_util` (`Dtype`) and `type_util_detail` (`DataType`) merged into a new compilation unit `dtype` fixes nv-morpheus#490 fixes nv-morpheus#456 Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: nv-morpheus#586
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableInfo
to Support Mutating a DataFrame from Multiple Threads #427PreallocatorMixin
which when added to a stage performs pre-allocation. This should be added to the first stage in a pipeline which emits a DataFrame or MessageMeta in a pipeline.MutableTableInfo
exposed to Python via a context manager to be used inwith
blockstype_util
(Dtype
) andtype_util_detail
(DataType
) merged into a new compilation unitdtype
fixes [FEA]: DataType & DType should be merged #490fixes #456