Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table locking & column preallocation #586

Merged
152 commits merged into from
Feb 6, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Dec 30, 2022

fixes #456

dagardner-nv and others added 30 commits October 27, 2022 16:55
deserialize stage to slice up the input and trigger the bug
…etection stage tests, also fix multi-segment tests
mdemoret-nv
mdemoret-nv previously approved these changes Jan 26, 2023
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lets target this for 23.03

@dagardner-nv dagardner-nv changed the base branch from branch-23.01 to branch-23.03 January 31, 2023 16:23
@dagardner-nv dagardner-nv dismissed mdemoret-nv’s stale review January 31, 2023 16:23

The base branch was changed.

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this in early in the cycle.

@dagardner-nv
Copy link
Contributor Author

/merge

@ghost ghost merged commit 778eba2 into nv-morpheus:branch-23.03 Feb 6, 2023
jjacobelli pushed a commit to jjacobelli/Morpheus that referenced this pull request Mar 7, 2023
* Builds on changes in nv-morpheus#427
* Adds a `PreallocatorMixin` which when added to a stage performs pre-allocation. This should be added to the first stage in a pipeline which emits a DataFrame or MessageMeta in a pipeline.
* Morpheus' TypeId enum exposed to the Python API, allowing stages to define types for columns needing pre-allocation
* `MutableTableInfo` exposed to Python via a context manager to be used in `with` blocks
* `type_util` (`Dtype`) and `type_util_detail` (`DataType`) merged into a new compilation unit `dtype` fixes nv-morpheus#490 


fixes nv-morpheus#456

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: nv-morpheus#586
@dagardner-nv dagardner-nv deleted the david-mdd_table-info-locking branch November 7, 2024 17:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request
Projects
Archived in project
2 participants