-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFP pipeline module #510
DFP pipeline module #510
Conversation
…s into dfp-pipeline-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the code quality looks good. Need a few things addressed regarding naming and commented code before merging. Also would like to discuss how modules should be used with @drobison00 before merging.
examples/digital_fingerprinting/production/morpheus/dfp/modules/dfp_pipeline_preprocessing.py
Outdated
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp/modules/dfp_pipeline_preprocessing.py
Outdated
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp/modules/dfp_rolling_window.py
Outdated
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp/utils/cached_user_window.py
Outdated
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp_azure_modules_pipeline.py
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp_azure_modules_pipeline.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. We can merge once the few remaining comments are resolved.
examples/digital_fingerprinting/production/morpheus/dfp/modules/dfp_data_prep.py
Outdated
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp_azure_modules_pipeline.py
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp/utils/module_ids.py
Show resolved
Hide resolved
…/Morpheus into dfp-pipeline-module
/merge |
column_info.py
tomorpheus.utils