Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFP pipeline module #510

Merged
64 commits merged into from
Jan 24, 2023
Merged

Conversation

bsuryadevara
Copy link
Contributor

@bsuryadevara bsuryadevara commented Nov 29, 2022

  • Morpheus modules implementation for DFP (Azure, Duo) pipeline training and preprocessing stages
  • Added modules utility
  • Moved column_info.py to morpheus.utils
  • Added tests
  • Updated digital fingerprinting production example README.md
  • Added dask and distributed packages
  • Updated DFP production examples notebooks

@bsuryadevara bsuryadevara self-assigned this Nov 29, 2022
@bsuryadevara bsuryadevara added the non-breaking Non-breaking change label Nov 30, 2022
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code quality looks good. Need a few things addressed regarding naming and commented code before merging. Also would like to discuss how modules should be used with @drobison00 before merging.

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. We can merge once the few remaining comments are resolved.

@mdemoret-nv
Copy link
Contributor

/merge

@ghost ghost merged commit 83479a5 into nv-morpheus:branch-23.01 Jan 24, 2023
@bsuryadevara bsuryadevara deleted the dfp-pipeline-module branch May 5, 2023 17:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: DFP Training Pipeline Using Module
3 participants