Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly calculate the offset of the column_view & apply offsets in copy_meta_ranges #423

Merged
19 commits merged into from
Oct 31, 2022
Merged

Properly calculate the offset of the column_view & apply offsets in copy_meta_ranges #423

19 commits merged into from
Oct 31, 2022

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 27, 2022 •
edited
Loading

fixes #424
fixes #425

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change 2 - In Progress labels Oct 27, 2022
@dagardner-nv dagardner-nv requested a review from a team as a code owner October 27, 2022 23:57
@dagardner-nv dagardner-nv changed the title Add unittest confirming bug in C++ impl of AddScoresStage MultiMessage::set_meta performs cudaMemcpy using cudf::type_dispatcher Oct 29, 2022
@dagardner-nv dagardner-nv changed the title MultiMessage::set_meta performs cudaMemcpy using cudf::type_dispatcher Properly calculate the offset of the column_view Oct 31, 2022
@dagardner-nv dagardner-nv changed the title Properly calculate the offset of the column_view Properly calculate the offset of the column_view & apply offsets in copy_meta_ranges Oct 31, 2022
mdemoret-nv
mdemoret-nv approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit d674d7d into nv-morpheus:branch-22.11 Oct 31, 2022
@dagardner-nv dagardner-nv mentioned this pull request Nov 2, 2022
Closed
@dagardner-nv dagardner-nv deleted the david-add-scores-bug branch November 7, 2024 17:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
2 participants
@dagardner-nv @mdemoret-nv