Fix broken developer guide code examples #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
non-breaking
dagardner-nv
added
2 - In Progress
and removed
improvement
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
|
rerun tests |
mdemoret-nv
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
I'm sure you saw the SRF quickstart CMake stuff: https://github.com/nv-morpheus/SRF/tree/branch-22.09/docs/quickstart.
Basically, we will want to do the same here. I'll make an issue to update the CMake here to be the same. In the mean time, this looks good as long as it compiles.
examples/developer_guide/2_2_rabbitmq/write_to_rabbitmq_stage.py
Outdated
Show resolved
Hide resolved
examples/developer_guide/4_rabbitmq_cpp_Stage/_lib/rabbitmq_source.cpp
Outdated
Show resolved
Hide resolved
examples/developer_guide/4_rabbitmq_cpp_Stage/cmake/Configure_SimpleAmqpClient.cmake
Outdated
Show resolved
Hide resolved
examples/developer_guide/4_rabbitmq_cpp_Stage/cmake/Configure_rabbitmq.cmake
Outdated
Show resolved
Hide resolved
examples/developer_guide/4_rabbitmq_cpp_Stage/cmake/Configure_rabbitmq.cmake
Outdated
Show resolved
Hide resolved
examples/developer_guide/4_rabbitmq_cpp_Stage/write_to_rabbitmq_stage.py
Outdated
Show resolved
Hide resolved
mdemoret-nv
force-pushed
the
branch-22.09
branch
from
1519baf to
e3efd45
Compare
dagardner-nv
force-pushed
the
david-broken-docs
branch
from
18a2b19 to
155b6e6
Compare
|
rerun tests |
|
@gpucibot merge |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292
Closes #219
Likely this should be updated once #312 is merged