Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nlp_si_detection example improvements #193

Merged
7 commits merged into from
Jun 27, 2022
Merged

nlp_si_detection example improvements #193

7 commits merged into from
Jun 27, 2022

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jun 24, 2022 •
edited
Loading

fixes #186

@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality 2 - In Progress labels Jun 24, 2022
@dagardner-nv dagardner-nv requested a review from a team as a code owner June 24, 2022 17:49
@dagardner-nv dagardner-nv mentioned this pull request Jun 24, 2022
Closed
@dagardner-nv dagardner-nv changed the title Draft: nlp_si_detection example improvements nlp_si_detection example improvements Jun 24, 2022
mdemoret-nv
mdemoret-nv requested changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions and one change for this PR.

examples/nlp_si_detection/README.md Show resolved Hide resolved
examples/nlp_si_detection/README.md Outdated Show resolved Hide resolved
examples/nlp_si_detection/README.md Outdated Show resolved Hide resolved
examples/nlp_si_detection/README.md Show resolved Hide resolved
morpheus/_lib/src/python_modules/messages.cpp Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv requested a review from mdemoret-nv June 27, 2022 18:03
mdemoret-nv
mdemoret-nv approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@dagardner-nv
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit d35593c into nv-morpheus:branch-22.06 Jun 27, 2022
@dagardner-nv dagardner-nv deleted the david-nlp-ex branch February 12, 2024 23:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @mdemoret-nv