Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown on Ctrl+C for Python source stages #1839

Merged
merged 19 commits into from
Aug 14, 2024
Merged

Fix shutdown on Ctrl+C for Python source stages #1839

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4c34d39
Implement stop method, and use a non-blocking call to queue.get, this…
dagardner-nv Aug 8, 2024
1955523
Move checking of stop_requested attribute to occur at the same time a…
dagardner-nv Aug 8, 2024
561b16b
Stop the http server on shutdown
dagardner-nv Aug 8, 2024
9417048
Move the stop method implemented in the kafka source stage to the bas…
dagardner-nv Aug 9, 2024
d4e7201
Remove, setting _stop_requested as this is now in the parent class
dagardner-nv Aug 9, 2024
ac86f05
wip
dagardner-nv Aug 9, 2024
bbb920d
Use non-blocking call to fetch from queue
dagardner-nv Aug 9, 2024
f27e8b0
Fix
dagardner-nv Aug 9, 2024
38fc546
Add a should_stop_fn callback to Watcher class
dagardner-nv Aug 9, 2024
7a12d43
Since we cannot pass a callback function to a module, as module confi…
dagardner-nv Aug 9, 2024
0ca515a
Since the interval time is often high (default is 10 minutes), rather…
dagardner-nv Aug 9, 2024
8fa5602
Remove unused import
dagardner-nv Aug 9, 2024
096aefd
Remove stop impl, this has been moved to the base class
dagardner-nv Aug 9, 2024
9e10924
Check is_stop_requested
dagardner-nv Aug 9, 2024
5412076
Use self.is_stop_requested() method, set type hint
dagardner-nv Aug 9, 2024
0a3fb0a
Update developer docs to reflect code changes
dagardner-nv Aug 9, 2024
8586673
Merge branch 'branch-24.10' into david-polling-source-stage-ctrl-c-18337
dagardner-nv Aug 13, 2024
9805dc8
Formatting fix
dagardner-nv Aug 14, 2024
e8be2a7
Merge branch 'branch-24.10' into david-polling-source-stage-ctrl-c-18337
dagardner-nv Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'branch-24.10' into david-polling-source-stage-ctrl-c-18337
  • Loading branch information
@dagardner-nv
dagardner-nv committed Aug 13, 2024
commit 85866733b491c5e4d59fdd4c8cf38754de534251

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.