-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce multi-endpoint servers and health check endpoints to HttpServerSourceStage #1734
Merged
rapids-bot
merged 9 commits into
nv-morpheus:branch-24.06
from
jadu-nv:jadu-http-server-source-endpoints
Jun 26, 2024
Merged
Introduce multi-endpoint servers and health check endpoints to HttpServerSourceStage #1734
rapids-bot
merged 9 commits into
nv-morpheus:branch-24.06
from
jadu-nv:jadu-http-server-source-endpoints
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endpoint, add endpoints
5eb5de2
to
68e7a8d
Compare
/ok to test |
/ok to test |
1 similar comment
/ok to test |
mdemoret-nv
approved these changes
Jun 26, 2024
…v/morpheus-dev into jadu-http-server-source-endpoints
/ok to test |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses: #1732
Currently, the
HttpServer
implementation does not support the initialization of a single server with multiple endpoints. This PR seeks to address this issue by refactoring theHttpServer
by taking a list ofHttpEndpoint
objects (encapsulates the attributes of an http endpoint, ie. url, method, endpoint handler).Additionally, this PR also introduces 2 endpoints to
HttpServerSourceStage
that allows users to conduct health checks on their pipelines.These endpoints are configurable by the user.
By Submitting this PR I confirm: