Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCA stage split: source + convert #1617

Merged
merged 48 commits into from
May 15, 2024
Merged

DOCA stage split: source + convert #1617

merged 48 commits into from
May 15, 2024

Conversation

e-ago
Copy link
Contributor

@e-ago e-ago commented Apr 11, 2024

Description

Split original DOCA Source Stage in two stages:

  • Source stage to receive and forward packets with the new RawPacketMessage
  • Convert stage to convert from RawPacketMessage to MessageMeta format

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@eagonv
Doca stage split: source + convert
716559c 
Signed-off-by: eagostini <eagostini@nvidia.com>
@e-ago e-ago requested a review from a team as a code owner April 11, 2024 11:48
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 11, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

eagonv added 3 commits April 11, 2024 11:52
@eagonv
Fix code style issues
9e7a163 
Signed-off-by: eagostini <eagostini@nvidia.com>
@eagonv
1 thread only for DOCA Source Stage
d266ca1
@eagonv
Progress in column creation
63ea2ad 
Signed-off-by: eagostini <eagostini@nvidia.com>
@e-ago e-ago requested a review from a team as a code owner April 12, 2024 14:19
@e-ago e-ago requested a review from a team as a code owner April 16, 2024 09:18
@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request labels Apr 16, 2024
@cwharris
Copy link
Contributor

/ok to test

mdemoret-nv
mdemoret-nv requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Mostly needs some cleanup to remove commented code and some extra changes which shouldnt be necessary anymore.

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/docker/optional_deps/doca.sh Outdated Show resolved Hide resolved
examples/doca/run_tcp.py Outdated Show resolved Hide resolved
morpheus/_lib/include/morpheus/messages/raw_packet.hpp Outdated Show resolved Hide resolved
morpheus/_lib/include/morpheus/messages/raw_packet.hpp Outdated Show resolved Hide resolved
morpheus/_lib/src/messages/raw_packet.cpp Outdated Show resolved Hide resolved
morpheus/stages/inference/inference_stage.py Outdated Show resolved Hide resolved
morpheus/stages/preprocess/preprocess_nlp_stage.py Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

/ok to test

eagonv added 2 commits May 9, 2024 15:53
@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

Merging before CI is passing since the errors are all in DOCA files.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 1e8518b into nv-morpheus:branch-24.06 May 15, 2024
3 checks passed
@dagardner-nv dagardner-nv mentioned this pull request Jun 24, 2024
Merged
rapids-bot bot pushed a commit that referenced this pull request Jun 24, 2024
@dagardner-nv
Provide a default set of questions for the standalone RAG pipeline (#…
b214137 
…1758)

* PR #1617 replaced the hard-coded questions with a command-line-flag, however it was not given a default value nor was it marked as a required flag.
* Set the original question as the default value for the flag

Requires #1755
Closes #1757


## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e-ago @cwharris @mdemoret-nv @eagonv