Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or silence warnings emitted during tests #1501

Merged
merged 67 commits into from
Feb 12, 2024
Merged

Fix or silence warnings emitted during tests #1501

merged 67 commits into from
Feb 12, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Feb 8, 2024 •
edited
Loading

Description

  • Reduce the number of warnings emitted while running tests
  • Replace usage of deprecated methods/attribues where possible
  • When no other option is avail, silence known warnings.
  • Remove out-of-date warning filters

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv
Ignore deprecation warnings from gputil
598a1db
@dagardner-nv
Suppress warnings from merlin/nvt regardning tensorflow not being ins…
0dc1816 
…talled
@dagardner-nv
Revert "Ignore deprecation warnings from gputil"
80575ca 
This reverts commit 598a1db.
@dagardner-nv
Ignore distutils deprecation warning
7a722bb
@dagardner-nv
Mark the http server tests as slow
0d1fa37
@dagardner-nv
Capture the warning emitted when timestamp is provided but timestamp …
da692e8 
…pattern is not
@dagardner-nv
Narrow the warning filters to be more specific, ensuring we aren't ac…
f1dcd44 
…cidentally ignoring other warnings
@dagardner-nv
Merge branch 'branch-24.03' of github.com:nv-morpheus/Morpheus into d…
374d6d6 
…avid-pytest-warnings
@dagardner-nv
Silence warnings about not having a config option
42614ec
@dagardner-nv
Avoid warning from cudf regardning an upcoming change of behavior whe…
074081e 
…n applying a groupby to a list with only a single element refer: https://github.com/rapidsai/cudf/blob/branch-24.02/python/cudf/cudf/core/groupby/groupby.py#L281
@dagardner-nv
Add comment explaining the special handling of single element lists
3a822c7
@dagardner-nv
WIP: need to find the root cause of this warning
3282475
@dagardner-nv
Update CR Year
a226c17
@dagardner-nv
Merge branch 'david-pytest-warnings' into david-pytest-warnings-p2
907f7d7
@dagardner-nv
Add comment explaining the warning coming from numpy 1.26
a0bbee2
@dagardner-nv
Merge branch 'branch-24.03' of github.com:nv-morpheus/Morpheus into d…
62915f5 
…avid-pytest-warnings-p2
@dagardner-nv
Update test for completion pipe to use actual asyncio futures, simila…
592f7f4 
…r to that used by the completion benchmark, this removes the need to mock the asyncio.gather method which is also used by the PromptTemplateNode
@dagardner-nv
Avoid warning about setting values on a copy
032ddec
@dagardner-nv
Ignore performance warnings from pandas triggered by the df compare m…
766d474 
…ethod in the tests
@dagardner-nv
Restrict numpy to versions prior to 1.25, this avoids numerous warnin…
5462726 
…gs triggered by cudf, more recent versions of cudf use this same version restriction
@dagardner-nv
Silence warning about cudf's subword tokenizer behaving differently t…
874776f 
…han huggingface
@dagardner-nv
Avoid pandas warning about setting a value on a copy
21d8562
@dagardner-nv
Ignore the warning from the logging_timer which happens whenever DFPS…
03168a2 
…plitUsersStage doesn't have any output messages
@dagardner-nv
Fix name of fixture resulting from bad copy/paste
062c214
@dagardner-nv
Replace deprecated usage of is_monotonic attribute with is_monotonic_…
a29cece 
…increasing and is_monotonic_decreasing
@dagardner-nv
Replace usage of deprecated on_start method in monitor stage
5154135
@dagardner-nv
Replace usage of deprecated on_start method in HttpServerSinkStage
e188d3a
@dagardner-nv
Update test to assert that a deprecation warning for on_start is prod…
71c7475 
…uced.
@dagardner-nv
Silence warning regarding tensorflow not being installed from nvt/merlin
90c79f5
@dagardner-nv
avoid deprecation warning about using .astype to convert from a tz-aw…
cb66ea0 
…are type to a tz-naive type
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality DO NOT MERGE PR should not be merged; see PR for details labels Feb 8, 2024
@dagardner-nv dagardner-nv self-assigned this Feb 8, 2024
@dagardner-nv dagardner-nv requested review from a team as code owners February 8, 2024 19:56
@dagardner-nv dagardner-nv marked this pull request as draft February 8, 2024 19:56
@dagardner-nv dagardner-nv mentioned this pull request Feb 8, 2024
Closed
@dagardner-nv dagardner-nv removed the DO NOT MERGE PR should not be merged; see PR for details label Feb 8, 2024
@dagardner-nv dagardner-nv marked this pull request as ready for review February 8, 2024 21:04
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ddd10d1 into nv-morpheus:branch-24.03 Feb 12, 2024
9 checks passed
@dagardner-nv dagardner-nv deleted the david-pytest-warnings-p3 branch February 12, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @mdemoret-nv