-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard optional dependencies in try/except blocks #1382
Guard optional dependencies in try/except blocks #1382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some questions. We can add these dependencies but they arent used in many situations. Can we get by with an import guard instead to instruct the user to install these packages if this particular node type is used?
…ight not be used by all users
…en we attempt to use them
…ove MILVUS_DATA_TYPE_MAP to tests/test_milvus_vector_db_service.py as it was the only place it was used
…avid-conda-deps-1380-p2
… it in an optional import, however the vdb service should be the entry point for users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better now. Will eventually need to re-address some of these in #1389
/merge |
Description
requests
,requests-cache
andwebsockets
tometa.yaml
meta.yaml
, even if they appear incuda11.8_dev.yml
bs4
,elasticsearch
,feedparser
andmilvus
MILVUS_DATA_TYPE_MAP
frommorpheus/service/vdb/milvus_client.py
totests/test_milvus_vector_db_service.py
which was the only place it was used.Note: Since these dependencies all exist in
cuda11.8_dev.yml
, there is no effort made to update the tests to optionally skip their associated tests.Closes #1380
By Submitting this PR I confirm: