-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source & stage decorators #1364
Add source & stage decorators #1364
Conversation
…kes 1.5m down from 5m
…rvice_fixture moved out of conftest
…ith MultiMessage however the Python impl accepts typing.Any. Re-work example to only use the C++ impl when the input type is a MultiMessage [no ci]
… first where the Python impl will be returned, the second where the C++ impl is returned [no ci]
…avid-stage-decorator-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start but we need some changes to be forward looking with these decorators. General changes:
- The classes used by the decorators should be "dumber" and move most of the implementation into the decorator instead of the class. See my comments for more details.
- Need some tests validating the parameters used at construction time
- Needs documentation showing how this can be used in the developer guide.
…avid-stage-decorator [no ci]
… thru impls, they will have different names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Like the changes. This will be super useful in the future.
/merge |
1 similar comment
/merge |
Description
source
andstage
allowing stages to be created from python functions.morpheus/pipeline/stage_base.py
example:
Closes #1253
By Submitting this PR I confirm: