Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Vector Database Service to allow stages to read and write to VDBs #1225

Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
5d7b3cb
Added milvus vdb prototype impl
bsuryadevara Sep 26, 2023
4807f3d
Added milvus vdb prototype impl
bsuryadevara Sep 26, 2023
b1f94fb
Added llamaindex and langchain prototypes
bsuryadevara Sep 27, 2023
d912645
doc updates
bsuryadevara Sep 27, 2023
4ecd37f
updates to milvus vd service
bsuryadevara Sep 30, 2023
c18125a
updated search and upsert functions
bsuryadevara Oct 2, 2023
a6ef60e
Added write_to_vector_db stage
bsuryadevara Oct 3, 2023
7389542
Added tests to get started
bsuryadevara Oct 3, 2023
3a31cee
Added tests to get started
bsuryadevara Oct 3, 2023
4cfba55
Added MilvusClient extension class to support missing functions
bsuryadevara Oct 4, 2023
b83f517
Added tests for Milvus vector database serivce
bsuryadevara Oct 4, 2023
b7fee57
Added tests for Milvus vector database service
bsuryadevara Oct 4, 2023
cde18b2
Added tests for Milvus vector database service
bsuryadevara Oct 4, 2023
c9316c0
Added milvus lite to pipeline tests
bsuryadevara Oct 9, 2023
36f1f18
Added tests with milvus lite
bsuryadevara Oct 11, 2023
2f24cc2
Updated Milvus VDB tests
bsuryadevara Oct 11, 2023
9670c97
Merge remote-tracking branch 'upstream/branch-23.11' into 1177-fea-ad…
bsuryadevara Oct 11, 2023
e4b8a02
Updated Milvus VDB tests
bsuryadevara Oct 11, 2023
a5e742e
Added tests with milvus lite
bsuryadevara Oct 11, 2023
3d0e01b
Renamed a file
bsuryadevara Oct 11, 2023
cd52a5f
Feedback changes
bsuryadevara Oct 12, 2023
5ce3402
Feedback changes
bsuryadevara Oct 12, 2023
9e6989a
Removed register stage decorator
bsuryadevara Oct 12, 2023
cf327b5
Ignore pymilvus in the docs
bsuryadevara Oct 13, 2023
a6a6f43
Update variable names
bsuryadevara Oct 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc updates
  • Loading branch information
bsuryadevara committed Sep 27, 2023
commit d9126455fe0617fcfa089680af0759082668bdfb
26 changes: 13 additions & 13 deletions morpheus/utils/vector_db_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,34 +44,34 @@ def wrapper(*args, **kwargs):
return decorator


def load_handler_by_path(handler_class_path, kwargs):
def load_controller_by_path(controller_class_path, kwargs):
bsuryadevara marked this conversation as resolved.
Show resolved Hide resolved
"""
Dynamically loads and instantiates a handler class specified by its import path.
Dynamically loads and instantiates a controller class specified by its import path.

Parameters
----------
handler_class_path : str
The import path to the handler class to be loaded.
controller_class_path : str
The import path to the controller class to be loaded.
kwargs : dict
A dictionary of keyword arguments to pass to the handler class constructor.
A dictionary of keyword arguments to pass to the controller class constructor.

Returns
-------
VectorDatabaseHandler
An instance of the loaded handler class.
VectorDatabaseController
An instance of the loaded controller class.

Raises
------
ImportError
If the specified module cannot be imported.
AttributeError
If no classes that inherit from VectorDatabaseHandler are found in the module.
If no classes that inherit from VectorDatabaseController are found in the module.
ValueError
If required constructor keyword arguments are missing or if no valid custom handler is found.
If required constructor keyword arguments are missing or if no valid custom controller is found.
"""

try:
module = importlib.import_module(handler_class_path)
module = importlib.import_module(controller_class_path)
for obj in inspect.getmembers(module):
if inspect.isclass(obj) and issubclass(obj, VectorDBController) and obj != VectorDBController:
handler_constructor_args = inspect.signature(obj.__init__).parameters.keys()
Expand All @@ -84,12 +84,12 @@ def load_handler_by_path(handler_class_path, kwargs):
)

return obj(**kwargs) # Instantiate with kwargs
raise ValueError(f"No valid custom handler found in the specified class path '{handler_class_path}'")
raise ValueError(f"No valid custom controller found in the specified class path '{controller_class_path}'")
except ImportError:
raise ImportError(
f"Failed to import module for the specified class path '{handler_class_path}'. Make sure the module exists."
f"Failed to import module for the specified class path '{controller_class_path}'. Make sure the module exists."
)
except AttributeError:
raise AttributeError(
f"No classes that inherit from VectorDatabaseHandler found in module for the specified class path '{handler_class_path}'"
f"No classes that inherit from VectorDatabaseController found in module for the specified class path '{controller_class_path}'"
)
Loading