Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break circular reference issue causing a memory leak #1115

Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
0d1aeb9
wip
dagardner-nv Aug 1, 2023
2a6e65e
Don't hold a reference to the pipeline outside of the build method, e…
dagardner-nv Aug 1, 2023
07b2069
Test for issue #1114
dagardner-nv Aug 1, 2023
5b5e3f4
Rename log parsing test to not conflict with top-level test_pipe
dagardner-nv Aug 2, 2023
7745d98
Pylint fixes
dagardner-nv Aug 2, 2023
73318c7
Don't hold a ref to executor options:
dagardner-nv Aug 2, 2023
364da5a
Skip test_multi_segment_bad_data_type due to MRC issue https://github…
dagardner-nv Aug 2, 2023
f85dea5
lint fixes
dagardner-nv Aug 2, 2023
698b3e4
Merge branch 'branch-23.11' into david-destructors-1114
dagardner-nv Aug 4, 2023
de11367
Ensure that both _storage_dir and _storage_type are defined prior to…
dagardner-nv Aug 15, 2023
506d95a
wip
dagardner-nv Aug 14, 2023
da1929c
Revert "wip"
dagardner-nv Aug 15, 2023
2909695
Add comment explaining
dagardner-nv Aug 15, 2023
7394f23
Call PyGILState_Check first to see if we need to gil, borrowed from M…
dagardner-nv Aug 15, 2023
0f7500c
Add comment explaining the call to PyGILState_Check
dagardner-nv Aug 15, 2023
34c038f
Test for MRC 362
dagardner-nv Aug 17, 2023
8984754
Insert CR header, and add fixture for disabling garbage collection
dagardner-nv Aug 17, 2023
7f2a553
Revert "Add comment explaining the call to PyGILState_Check"
dagardner-nv Aug 17, 2023
f061115
Revert "Call PyGILState_Check first to see if we need to gil, borrowe…
dagardner-nv Aug 17, 2023
33cf054
Adopt patched pybind11
dagardner-nv Aug 18, 2023
5163bc9
Merge branch 'branch-23.11' of github.com:nv-morpheus/Morpheus into d…
dagardner-nv Aug 18, 2023
60d20e3
Lint fixes
dagardner-nv Aug 18, 2023
123d730
Merge branch 'branch-23.11' into david-destructors-1114
dagardner-nv Aug 22, 2023
5bd3ade
Merge branch 'branch-23.11' into david-destructors-1114
dagardner-nv Aug 24, 2023
07b284a
Merge branch 'branch-23.11' of github.com:nv-morpheus/Morpheus into d…
dagardner-nv Aug 24, 2023
8b95b65
Merge branch 'branch-23.11' of github.com:nv-morpheus/Morpheus into d…
dagardner-nv Aug 30, 2023
9bbc515
Cleanups per pr feedback
dagardner-nv Aug 30, 2023
e4f24ca
yapf formatting fixes
dagardner-nv Aug 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment explaining the call to PyGILState_Check
  • Loading branch information
dagardner-nv committed Aug 15, 2023
commit 0f7500c1210965ad149b22dac4bd10c86e13eec3
2 changes: 2 additions & 0 deletions morpheus/_lib/src/objects/python_data_table.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ PyDataTable::~PyDataTable()
{
if (m_py_table)
{
// Check to see if we need to grab the GIL. If we are being destroyed by the Python GC we actually don't need
// to and don't want to aquire the GIL using pybind11 because it will trigger a pybind11 internal error.
if (PyGILState_Check() == 0)
{
pybind11::gil_scoped_acquire gil;
Expand Down