-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve gitutils.py
by using the Github CLI when available
#1088
Merged
rapids-bot
merged 12 commits into
nv-morpheus:branch-23.11
from
mdemoret-nv:mdd_fix-gitutils
Aug 17, 2023
Merged
Improve gitutils.py
by using the Github CLI when available
#1088
rapids-bot
merged 12 commits into
nv-morpheus:branch-23.11
from
mdemoret-nv:mdd_fix-gitutils
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
added
non-breaking
Non-breaking change
improvement
Improvement to existing functionality
labels
Jul 21, 2023
dagardner-nv
approved these changes
Aug 17, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
gitutils.py
script often fails when you are working in a PR, or if there has been a commit to your target branch since you created your current branch.This improves the utility by using the Github CLI to query the PR information when possible and get the true target branch for the current PR.
If the Github CLI is not available, or the branch isnt in a PR, it falls back to the previous functionality.