Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Expected/Error from internal -> core #263

Merged
2 commits merged into from
Jan 13, 2023

Conversation

ryanolson
Copy link
Contributor

No description provided.

@ryanolson ryanolson added the improvement Improvement to existing functionality label Dec 27, 2022
@ryanolson ryanolson requested a review from a team as a code owner December 27, 2022 04:47
@ryanolson ryanolson self-assigned this Dec 27, 2022
@ryanolson ryanolson added the non-breaking Non-breaking change label Dec 27, 2022
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #263 (cb51342) into branch-23.01 (0151a7a) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.01     #263      +/-   ##
================================================
- Coverage         72.52%   72.49%   -0.03%     
================================================
  Files               376      376              
  Lines             12082    12082              
  Branches            921      921              
================================================
- Hits               8762     8759       -3     
- Misses             3320     3323       +3     
Flag Coverage Δ
cpp 69.32% <66.66%> (-0.04%) ⬇️
py 38.32% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/include/mrc/core/expected.hpp 71.02% <ø> (ø)
cpp/mrc/src/internal/control_plane/client.hpp 68.96% <ø> (ø)
...ernal/control_plane/client/connections_manager.cpp 70.42% <ø> (ø)
...rc/internal/control_plane/client/state_manager.cpp 86.66% <ø> (ø)
...rnal/control_plane/client/subscription_service.cpp 0.00% <ø> (ø)
...p/mrc/src/internal/control_plane/proto_helpers.hpp 40.00% <ø> (ø)
cpp/mrc/src/internal/control_plane/server.cpp 40.06% <0.00%> (ø)
cpp/mrc/src/internal/control_plane/server.hpp 100.00% <ø> (ø)
cpp/mrc/src/tests/test_expected.cpp 85.41% <ø> (ø)
cpp/mrc/include/mrc/core/error.hpp 83.33% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0151a7a...cb51342. Read the comment docs.

@mdemoret-nv
Copy link
Contributor

/merge

@ghost ghost merged commit 57abd43 into nv-morpheus:branch-23.01 Jan 13, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants