Refactor serialization logic and reorganize contracts.#11
Merged
Conversation
Replaced `InvalidRefiner::from` with a more specific `emptyTypeContexts` method, simplifying error handling. Moved `SerializesArrayOfItems` interface to the proper namespace under `Serializers\Contracts`. Adjusted serialization and deserialization error handling with a cleaner and more consistent structure. Updated test coverage paths in configuration.
Fa-BRAIK
added
the
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve exception handling and code organization in the serialization and deserialization processes. The most important changes include the introduction of new exception methods, modifications to existing exception handling, and updates to namespace and contract usage.
Improvements to exception handling:
src/Concerns/BaseData.php: Replaced direct instantiation ofDeserializeExceptionandSerializeExceptionwith static methods for more specific error messages and codes. [1] [2] [3] [4]src/Contexts/PropertyContext.php: Updated exception handling to use the new static methods fromDeserializeExceptionandSerializeException. [1] [2] [3]src/DataRefiners/DateTimeRefiner.php: Replaced theInvalidRefiner::frommethod withInvalidRefiner::emptyTypeContextsfor more specific error handling.Code organization and namespace updates:
src/Exceptions/DeserializeException.php: Added new static methods to handle various deserialization errors with specific error codes.src/Exceptions/SerializeException.php: Added new static methods to handle various serialization errors with specific error codes.src/Serializers/ArraySerializer.php,src/Serializers/BackedEnumSerializer.php,src/Serializers/DataSerializer.php: Updated to use the newSerializesArrayOfItemscontract and moved the contract to a new namespace. [1] [2] [3] [4] [5]These changes collectively enhance the clarity and maintainability of the codebase by providing more specific error handling and improving the organization of contracts and namespaces.