Conversation
commit: |
Member
|
thank you! one thing is that there's a lot of overlap between the two implementations i keep meaning to refactor out the shared pieces so bug fixes in one propagate to the other |
Collaborator
Author
|
thank you for the review as always. |
cbb27bc to
a6fadb7
Compare
renderSuspended30142b8 to
ae85d40
Compare
Collaborator
Author
|
thank you for the advice. |
ae85d40 to
fe365a8
Compare
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Unified the underlying logic of the
mountSuspendedandrenderSuspended.This also fixes the missing setup logic for vueApp.context.components in renderSuspended.