Skip to content

feat(runtime-utils): unify logic of mount + render helpers#1522

Merged
danielroe merged 1 commit intonuxt:mainfrom
yamachi4416:fix/pass-context-components-render-helper
Dec 31, 2025
Merged

feat(runtime-utils): unify logic of mount + render helpers#1522
danielroe merged 1 commit intonuxt:mainfrom
yamachi4416:fix/pass-context-components-render-helper

Conversation

@yamachi4416
Copy link
Collaborator

@yamachi4416 yamachi4416 commented Dec 20, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Unified the underlying logic of the mountSuspended and renderSuspended.
This also fixes the missing setup logic for vueApp.context.components in renderSuspended.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/test-utils@1522

commit: ae85d40

@yamachi4416 yamachi4416 marked this pull request as ready for review December 20, 2025 00:49
@danielroe
Copy link
Member

thank you!

one thing is that there's a lot of overlap between the two implementations

i keep meaning to refactor out the shared pieces so bug fixes in one propagate to the other

@yamachi4416
Copy link
Collaborator Author

yamachi4416 commented Dec 20, 2025

thank you for the review as always.
You're absolutely right. I'm going to refactor it to pull out the shared logic.

@yamachi4416 yamachi4416 marked this pull request as draft December 20, 2025 10:34
@yamachi4416 yamachi4416 force-pushed the fix/pass-context-components-render-helper branch from cbb27bc to a6fadb7 Compare December 24, 2025 23:28
@yamachi4416 yamachi4416 changed the title fix(runtime-utils): pass app context components to renderSuspended fix(runtime-utils): unify logic of mount + render helpers Dec 24, 2025
@yamachi4416 yamachi4416 force-pushed the fix/pass-context-components-render-helper branch 3 times, most recently from 30142b8 to ae85d40 Compare December 26, 2025 11:19
@yamachi4416 yamachi4416 marked this pull request as ready for review December 26, 2025 12:05
@yamachi4416
Copy link
Collaborator Author

thank you for the advice.
I’ve refactored the internal logic of mountSuspended and renderSuspended to share common code.
I would appreciate it if you could take a look.

@yamachi4416 yamachi4416 force-pushed the fix/pass-context-components-render-helper branch from ae85d40 to fe365a8 Compare December 31, 2025 00:54
@yamachi4416 yamachi4416 changed the title fix(runtime-utils): unify logic of mount + render helpers feat(runtime-utils): unify logic of mount + render helpers Dec 31, 2025
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! ❤️

@danielroe danielroe merged commit 58773a7 into nuxt:main Dec 31, 2025
5 of 6 checks passed
@github-actions github-actions bot mentioned this pull request Dec 31, 2025
@yamachi4416 yamachi4416 deleted the fix/pass-context-components-render-helper branch December 31, 2025 23:47
adamdehaven added a commit to adamdehaven/test-utils that referenced this pull request Jan 23, 2026
The nextTick import apepars to have been unintentionally removed in nuxt#1522. This pull request restores the missing import and fixes nuxt#1562.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants