Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit synthetic load/error events on initial hydration #842

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

danielroe
Copy link
Member

resolves #682
resolves #412

This PR emits load/error events on initial hydration for better DX if the load/error event has already occurred before hydration.

@danielroe danielroe added the bug Something isn't working label May 31, 2023
@danielroe danielroe self-assigned this May 31, 2023
@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for nuxt-image-v1 ready!

Name Link
🔨 Latest commit e9be02c
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/647f369e4cb8230008af1e9f
😎 Deploy Preview https://deploy-preview-842--nuxt-image-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe marked this pull request as ready for review May 31, 2023 20:58
@danielroe danielroe requested a review from pi0 May 31, 2023 20:59
@pi0 pi0 merged commit 03001e5 into main Jun 6, 2023
@pi0 pi0 deleted the fix/hydration-events branch June 6, 2023 13:42
@pi0 pi0 mentioned this pull request Jun 6, 2023
@TheNaschkatze
Copy link

wiii!

@onkar-rentomojo
Copy link

@error is still not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@load - Not Firing - Nuxt 3 "error" event not firing on nuxt-img
4 participants