fix: override user-defined format/screens/densities module options#2138
fix: override user-defined format/screens/densities module options#2138DamianGlowala wants to merge 4 commits intomainfrom
format/screens/densities module options#2138Conversation
Deploying nuxt-image with
|
| Latest commit: |
dac3aef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d28e7d62.nuxt-image.pages.dev |
| Branch Preview URL: | https://fix-module-options-overridin.nuxt-image.pages.dev |
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDefaults for array/object image options were moved from module-definition time to setup-time normalization. The explicit type assertion for Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@playground/nuxt.config.ts`:
- Line 19: The formats array in playground/nuxt.config.ts currently contains
both 'jpg' and 'jpeg' which are aliases and can cause inconsistent provider
behavior; update the formats array (the format entry used by the image provider
config) to use a single canonical value (prefer 'jpeg') or explicitly
document/justify keeping both if testing aliases, and ensure the chosen value
works with your targeted providers (notably hygraph which only accepts 'jpg').
🔗 Linked issue
resolves #1874
resolves #2020
📚 Description
This moves non-empty arrays and objects from
defaultsofdefineNuxtModuleto setup block, so that they are not affected by default merging behaviour.