Skip to content

Conversation

OrbisK
Copy link
Member

@OrbisK OrbisK commented Jul 9, 2025

πŸ”— Linked issue

fixes #948 fixes nuxt/nuxt#32571

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR disables the socket usage on stackblitz. It does also allow opting out of sockets via NUXT_SOCKET=0

@OrbisK OrbisK requested a review from danielroe as a code owner July 9, 2025 15:11
Copy link

pkg-pr-new bot commented Jul 9, 2025

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@949
npm i https://pkg.pr.new/nuxi@949
npm i https://pkg.pr.new/@nuxt/cli@949

commit: 39b535c

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@048ad16). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/dev.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #949   +/-   ##
=======================================
  Coverage        ?   12.50%           
=======================================
  Files           ?       74           
  Lines           ?     3901           
  Branches        ?      112           
=======================================
  Hits            ?      488           
  Misses          ?     3379           
  Partials        ?       34           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codspeed-hq bot commented Jul 9, 2025

CodSpeed Performance Report

Merging #949 will not alter performance

Comparing OrbisK:stackblitz-dev-socket (39b535c) with main (048ad16)

Summary

βœ… 2 untouched benchmarks

@OrbisK OrbisK changed the title wip: dont use sockets to test stackblitz dev server fix: don't use sockets if provider is stackblitz Jul 9, 2025
@OrbisK OrbisK changed the title fix: don't use sockets if provider is stackblitz WIP: fix: don't use sockets if provider is stackblitz Jul 9, 2025
@OrbisK OrbisK changed the title WIP: fix: don't use sockets if provider is stackblitz fix: don't use sockets if provider is stackblitz Jul 9, 2025
@danielroe danielroe merged commit ddb6d80 into nuxt:main Jul 9, 2025
11 of 14 checks passed
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nuxt dev | V4 stackblitz crashes with Failed to parse http message V4 stackblitz crashes with Failed to parse http message

3 participants