Skip to content

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 18, 2025

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I expect this to be a significant improvement when running nuxt dev, but this PR is very much work-in-progress.

🚧 TODO

  • consider disabling for Nuxt versions pre-v3.18

🚧 Issues to investigate

Copy link
Contributor

github-actions bot commented Jun 18, 2025

Bundle Stats β€” create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
49 5.89 MB β†’ 5.89 MB (+2.81 kB) +0.05%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/dev/socket.ts πŸ†• +1.98 kB 0 B β†’ 1.98 kB
home/runner/work/cli/cli/packages/nuxi/src/dev/utils.ts πŸ“ˆ +383 B (+4.42%) 8.47 kB β†’ 8.84 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts πŸ“ˆ +430 B (+4.16%) 10.1 kB β†’ 10.52 kB
home/runner/work/cli/cli/packages/nuxi/src/dev/index.ts πŸ“ˆ +36 B (+1.31%) 2.69 kB β†’ 2.72 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/index2.mjs 194.26 kB β†’ 196.65 kB (+2.39 kB) +1.23%
chunks/dev.mjs 27.24 kB β†’ 27.66 kB (+430 B) +1.54%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 1.07 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/add.mjs 6.89 kB 0%
chunks/analyze.mjs 3.27 kB 0%
chunks/build.mjs 1.96 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 811 B 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 472 B 0%
chunks/info.mjs 4.38 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.5 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.91 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/prompt.mjs 42.91 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/jiti.mjs 305 B 0%
chunks/index3.mjs 71.97 kB 0%
chunks/add2.mjs 12.08 kB 0%
chunks/search.mjs 45.85 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 145.67 kB 0%
chunks/index4.mjs 1.23 kB 0%
chunks/index5.mjs 5.85 kB 0%
chunks/index6.mjs 6.24 kB 0%
chunks/index7.mjs 50.51 kB 0%
chunks/index8.mjs 898.9 kB 0%
shared/create-nuxt.B3STrcyM.mjs 964.43 kB 0%
shared/create-nuxt.BGY4dUiI.mjs 792 B 0%
shared/create-nuxt.Bls702kr.mjs 294 B 0%
shared/create-nuxt.CTZIz834.mjs 3.9 kB 0%
shared/create-nuxt.BSm0_9Hr.mjs 107 B 0%
shared/create-nuxt.DX9WOARL.mjs 108.11 kB 0%
shared/create-nuxt.C_rHbSeB.mjs 18.91 kB 0%
shared/create-nuxt.Drn2Mj-1.mjs 1.17 MB 0%
shared/create-nuxt.bOUheP_L.mjs 4.07 kB 0%
shared/create-nuxt.DbuVfATn.mjs 836 B 0%
shared/create-nuxt.BGD2CGTI.mjs 945 B 0%
shared/create-nuxt.CssRAp0b.mjs 15.27 kB 0%
shared/create-nuxt.DThhmweU.mjs 2.02 MB 0%
shared/create-nuxt.BjhZEm2-.mjs 1.75 kB 0%
shared/create-nuxt.BEnMq1Re.mjs 4.06 kB 0%
shared/create-nuxt.Vk1IrVtB.mjs 26.96 kB 0%
shared/create-nuxt.4t9faemh.mjs 43.64 kB 0%

Copy link
Contributor

github-actions bot commented Jun 18, 2025

Bundle Stats β€” nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
32 90.28 kB β†’ 93.08 kB (+2.8 kB) +3.10%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/dev/socket.ts πŸ†• +1.97 kB 0 B β†’ 1.97 kB
home/runner/work/cli/cli/packages/nuxi/src/dev/utils.ts πŸ“ˆ +381 B (+4.40%) 8.46 kB β†’ 8.83 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts πŸ“ˆ +430 B (+4.16%) 10.09 kB β†’ 10.51 kB
home/runner/work/cli/cli/packages/nuxi/src/dev/index.ts πŸ“ˆ +36 B (+1.32%) 2.67 kB β†’ 2.7 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/index.mjs 11.43 kB β†’ 13.81 kB (+2.38 kB) +20.84%
chunks/dev.mjs 10.09 kB β†’ 10.51 kB (+430 B) +4.16%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
dev/index.mjs 0 B 0%
index.mjs 236 B 0%
chunks/analyze.mjs 3.27 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 815 B 0%
chunks/devtools.mjs 763 B 0%
chunks/generate.mjs 472 B 0%
chunks/build.mjs 1.96 kB 0%
chunks/info.mjs 4.39 kB 0%
chunks/index2.mjs 273 B 0%
chunks/add.mjs 10.17 kB 0%
chunks/search.mjs 2.96 kB 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.5 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.91 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/init.mjs 9.85 kB 0%
chunks/add2.mjs 6.89 kB 0%
shared/cli.B9AmABr3.mjs 39 B 0%
shared/cli.Dz2be-Ai.mjs 792 B 0%
shared/cli.BEUGgaW4.mjs 294 B 0%
shared/cli.BSm0_9Hr.mjs 107 B 0%
shared/cli.At9IMXtr.mjs 1.23 kB 0%
shared/cli.pLQ0oPGc.mjs 836 B 0%
shared/cli.qKvs7FJ2.mjs 945 B 0%
shared/cli.P0cplz3M.mjs 78 B 0%
shared/cli.jA1DRKbi.mjs 1.04 kB 0%
shared/cli.BLVI_04J.mjs 1.8 kB 0%
shared/cli.yHMpVeHl.mjs 5.42 kB 0%

Copy link
Contributor

github-actions bot commented Jun 18, 2025

Bundle Stats β€” nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
58 5.46 MB β†’ 5.46 MB (+2.81 kB) +0.05%
Changeset
File Ξ” Size
src/dev/socket.ts πŸ†• +1.98 kB 0 B β†’ 1.98 kB
src/dev/utils.ts πŸ“ˆ +383 B (+4.42%) 8.47 kB β†’ 8.84 kB
src/commands/dev.ts πŸ“ˆ +430 B (+4.16%) 10.1 kB β†’ 10.52 kB
src/dev/index.ts πŸ“ˆ +36 B (+1.31%) 2.69 kB β†’ 2.72 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/index2.mjs 194.26 kB β†’ 196.65 kB (+2.39 kB) +1.23%
chunks/dev.mjs 27.24 kB β†’ 27.66 kB (+430 B) +1.54%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 247 B 0%
dev/index.mjs 896 B 0%
chunks/add.mjs 6.89 kB 0%
chunks/analyze.mjs 3.27 kB 0%
chunks/build.mjs 1.96 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 780 B 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 472 B 0%
chunks/info.mjs 4.38 kB 0%
chunks/init.mjs 665.88 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.5 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.91 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.3 kB 0%
chunks/prompt.mjs 42.91 kB 0%
chunks/jiti.mjs 305 B 0%
chunks/index3.mjs 71.97 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add2.mjs 12.08 kB 0%
chunks/search.mjs 45.85 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 145.67 kB 0%
chunks/index4.mjs 1.23 kB 0%
chunks/index5.mjs 5.85 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/index6.mjs 898.9 kB 0%
shared/nuxi.DFIyyeua.mjs 19.18 kB 0%
shared/nuxi.Dh2ZdpAd.mjs 57.22 kB 0%
shared/nuxi.CTyTlDmo.mjs 18.91 kB 0%
shared/nuxi.DzMZtGWH.mjs 792 B 0%
shared/nuxi.BtDT0y5R.mjs 294 B 0%
shared/nuxi.Cm5apyPX.mjs 2.57 kB 0%
shared/nuxi.Db0skjkt.mjs 915.23 kB 0%
shared/nuxi.D2_bzAv0.mjs 1.54 kB 0%
shared/nuxi.DtQ0anGB.mjs 4.07 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.DMyZmNH9.mjs 836 B 0%
shared/nuxi.BiWTNJI4.mjs 945 B 0%
shared/nuxi.BMIgfYLN.mjs 15.26 kB 0%
shared/nuxi.ChutbOY_.mjs 25.34 kB 0%
shared/nuxi.D5KtpA0t.mjs 984 B 0%
shared/nuxi.wc1-AWrO.mjs 2.02 MB 0%
shared/nuxi.BjhZEm2-.mjs 1.75 kB 0%
shared/nuxi.BEgIcxrx.mjs 4.06 kB 0%
shared/nuxi.DU9QXUOf.mjs 26.96 kB 0%
shared/nuxi.BzZJv2UC.mjs 123.67 kB 0%
shared/nuxi.QWnQy_ku.mjs 5.75 kB 0%
shared/nuxi.CbyJ5osS.mjs 13.45 kB 0%
shared/nuxi.BLb4POFS.mjs 42.47 kB 0%
shared/nuxi.Do0aYBCO.mjs 5.46 kB 0%
shared/nuxi.4t9faemh.mjs 43.64 kB 0%

Copy link

pkg-pr-new bot commented Jun 18, 2025

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@921
npm i https://pkg.pr.new/nuxi@921
npm i https://pkg.pr.new/@nuxt/cli@921

commit: 5645518

Copy link

codspeed-hq bot commented Jun 18, 2025

CodSpeed Performance Report

Merging #921 will degrade performances by 10.17%

Comparing feat/socket-remake (5645518) with main (599c4d2)

Summary

❌ 1 regressions
βœ… 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ makes requests to dev server 91.6 ms 102 ms -10.17%

@danielroe danielroe marked this pull request as ready for review July 1, 2025 12:27
@danielroe danielroe merged commit 99b4136 into main Jul 1, 2025
14 checks passed
@danielroe danielroe deleted the feat/socket-remake branch July 1, 2025 13:34
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant