Skip to content

Conversation

DamianGlowala
Copy link
Member

πŸ”— Linked issue

resolves #754

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

POC for the interactive modules selector - feedback and suggestions are welcome!

@DamianGlowala DamianGlowala requested a review from danielroe as a code owner March 7, 2025 19:24
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Bundle Stats β€” create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
50 β†’ 49 5.71 MB β†’ 5.72 MB (+2.21 kB) +0.04%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/commands/init.ts πŸ“ˆ +1.1 kB (+18.21%) 6.02 kB β†’ 7.11 kB
node_modules/node-fetch-native/dist/index.mjs πŸ“ˆ +22 B (+5.76%) 382 B β†’ 404 B
node_modules/node-fetch-native/dist/node.mjs πŸ“ˆ +968 B (+0.86%) 110.04 kB β†’ 110.99 kB
node_modules/ofetch/dist/node.mjs πŸ“ˆ +6 B (+0.71%) 840 B β†’ 846 B
node_modules/tinyexec/dist/main.js πŸ“ˆ +50 B (+0.32%) 15.38 kB β†’ 15.43 kB
node_modules/giget/dist/shared/giget.OCaTp9b-.mjs πŸ“ˆ +88 B (+0.10%) 82.26 kB β†’ 82.34 kB
node_modules/nypm/dist/shared/nypm.Bcw9TJOu.mjs πŸ“ˆ +4 B (+0.04%) 10.03 kB β†’ 10.03 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/module/add.ts πŸ“ˆ +3 B (+0.03%) 10.32 kB β†’ 10.32 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/create-nuxt.C8xw6lex.mjs 0 B β†’ 2.02 MB (+2.02 MB) -
shared/create-nuxt.DPNCFUgS.mjs 0 B β†’ 944.96 kB (+944.96 kB) -
shared/create-nuxt.Tuub8dkf.mjs 0 B β†’ 108.13 kB (+108.13 kB) -
shared/create-nuxt.Bg2MsAUI.mjs 0 B β†’ 18.95 kB (+18.95 kB) -
shared/create-nuxt.Bp9rbz1P.mjs 0 B β†’ 14.64 kB (+14.64 kB) -
shared/create-nuxt.Umjto0iq.mjs 0 B β†’ 4.07 kB (+4.07 kB) -
shared/create-nuxt.Db5w2sD5.mjs 0 B β†’ 3.9 kB (+3.9 kB) -
shared/create-nuxt.bP8fxh52.mjs 0 B β†’ 836 B (+836 B) -
shared/create-nuxt.zXdOcxCQ.mjs 0 B β†’ 804 B (+804 B) -
shared/create-nuxt.Bz07-tpP.mjs 0 B β†’ 715 B (+715 B) -
shared/create-nuxt.BMcmU3YJ.mjs 0 B β†’ 294 B (+294 B) -

Removed

Asset File Size % Changed
shared/create-nuxt.D9Zp2tmc.mjs 2.02 MB β†’ 0 B (-2.02 MB) -100%
shared/create-nuxt.Bw4C01GA.mjs 813.58 kB β†’ 0 B (-813.58 kB) -100%
shared/create-nuxt.28hIKy78.mjs 124.17 kB β†’ 0 B (-124.17 kB) -100%
shared/create-nuxt.B2M82CyS.mjs 108.13 kB β†’ 0 B (-108.13 kB) -100%
shared/create-nuxt.CWMKGdSL.mjs 18.95 kB β†’ 0 B (-18.95 kB) -100%
shared/create-nuxt.BvXIVLlc.mjs 14.64 kB β†’ 0 B (-14.64 kB) -100%
shared/create-nuxt.D4vggcPe.mjs 5.7 kB β†’ 0 B (-5.7 kB) -100%
shared/create-nuxt.DYeRjsmu.mjs 4.07 kB β†’ 0 B (-4.07 kB) -100%
shared/create-nuxt.Cwoc3yC8.mjs 3.9 kB β†’ 0 B (-3.9 kB) -100%
shared/create-nuxt.DGBHnbi1.mjs 836 B β†’ 0 B (-836 B) -100%
shared/create-nuxt.BLwMXuQM.mjs 804 B β†’ 0 B (-804 B) -100%
shared/create-nuxt.BU1dypMe.mjs 294 B β†’ 0 B (-294 B) -100%

Bigger

Asset File Size % Changed
chunks/add2.mjs 12.21 kB β†’ 12.21 kB (+3 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 1.07 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.96 kB 0%
chunks/dev.mjs 7.48 kB 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.22 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.25 kB 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/kit.mjs 1.34 kB 0%
chunks/index2.mjs 1.17 MB 0%
chunks/dev2.mjs 70 kB 0%
chunks/index3.mjs 17.14 kB 0%
chunks/index4.mjs 71.98 kB 0%
chunks/search.mjs 45.83 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.23 kB 0%
chunks/index5.mjs 1.23 kB 0%
chunks/index6.mjs 6.25 kB 0%
chunks/index7.mjs 50.51 kB 0%
chunks/index8.mjs 5.85 kB 0%
chunks/index9.mjs 885.9 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
shared/create-nuxt.BSm0_9Hr.mjs 107 B 0%
shared/create-nuxt.jjur9XJH.mjs 43.55 kB 0%
shared/create-nuxt.BjhZEm2-.mjs 1.75 kB 0%
shared/create-nuxt.DnK9Crop.mjs 26.94 kB 0%

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Bundle Stats β€” nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
54 β†’ 55 5.29 MB β†’ 5.29 MB (+1.1 kB) +0.02%
Changeset
File Ξ” Size
src/commands/init.ts πŸ“ˆ +1.09 kB (+18.18%) 6.01 kB β†’ 7.11 kB
src/commands/module/add.ts πŸ“ˆ +3 B (+0.03%) 10.32 kB β†’ 10.32 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/nuxi.B8RZQP9m.mjs 0 B β†’ 123.47 kB (+123.47 kB) -
shared/nuxi.CIIOD_vg.mjs 0 B β†’ 715 B (+715 B) -

Removed

Asset File Size % Changed
shared/nuxi.CHtkLRvK.mjs 124.17 kB β†’ 0 B (-124.17 kB) -100%

Bigger

Asset File Size % Changed
chunks/init.mjs 662.47 kB β†’ 663.56 kB (+1.09 kB) +0.17%
chunks/add2.mjs 12.21 kB β†’ 12.21 kB (+3 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 210 B 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.96 kB 0%
chunks/dev.mjs 7.48 kB 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.22 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.25 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.3 kB 0%
chunks/index2.mjs 915.2 kB 0%
chunks/dev2.mjs 70 kB 0%
chunks/index3.mjs 17.14 kB 0%
chunks/index4.mjs 71.98 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/search.mjs 45.83 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.23 kB 0%
chunks/index5.mjs 1.23 kB 0%
chunks/index6.mjs 5.85 kB 0%
chunks/index7.mjs 885.9 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
shared/nuxi.BKSvbvjM.mjs 76.15 kB 0%
shared/nuxi.DqkIr2yV.mjs 18.95 kB 0%
shared/nuxi.Bvkha4gC.mjs 804 B 0%
shared/nuxi.D7n12WIr.mjs 294 B 0%
shared/nuxi.BfmaxnpL.mjs 2.57 kB 0%
shared/nuxi.D2_bzAv0.mjs 1.54 kB 0%
shared/nuxi.BGsL6WwO.mjs 4.07 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.BeSCWecd.mjs 836 B 0%
shared/nuxi._8J0PkaN.mjs 1.34 kB 0%
shared/nuxi.CoaHqGOR.mjs 14.64 kB 0%
shared/nuxi.BcEzdr5W.mjs 10.03 kB 0%
shared/nuxi.BjycWew7.mjs 2.02 MB 0%
shared/nuxi.E-ZsRS8r.mjs 943 B 0%
shared/nuxi.BjhZEm2-.mjs 1.75 kB 0%
shared/nuxi.Kph9bHCN.mjs 26.94 kB 0%
shared/nuxi.D4vggcPe.mjs 5.7 kB 0%
shared/nuxi.JlPZHmu9.mjs 53.93 kB 0%
shared/nuxi.Do0aYBCO.mjs 5.46 kB 0%
shared/nuxi.jjur9XJH.mjs 43.55 kB 0%

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Bundle Stats β€” nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
30 81.18 kB β†’ 82.27 kB (+1.09 kB) +1.35%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/commands/init.ts πŸ“ˆ +1.09 kB (+18.22%) 5.99 kB β†’ 7.08 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/module/add.ts πŸ“ˆ +3 B (+0.03%) 10.3 kB β†’ 10.31 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/init.mjs 6.36 kB β†’ 7.45 kB (+1.09 kB) +17.17%
chunks/add2.mjs 10.3 kB β†’ 10.31 kB (+3 B) +0.03%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 224 B 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.97 kB 0%
chunks/dev.mjs 7.43 kB 0%
chunks/devtools.mjs 763 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.22 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.25 kB 0%
chunks/dev2.mjs 8.16 kB 0%
chunks/search.mjs 2.94 kB 0%
shared/cli.CDrfLbqq.mjs 5.5 kB 0%
shared/cli.BMVuNG7k.mjs 804 B 0%
shared/cli.ApkskrXk.mjs 294 B 0%
shared/cli.D7GNsoFG.mjs 1.23 kB 0%
shared/cli.BSm0_9Hr.mjs 107 B 0%
shared/cli.BhrZatnq.mjs 836 B 0%
shared/cli.DlcAx0De.mjs 1.04 kB 0%
shared/cli.CCorTjsv.mjs 1.72 kB 0%
shared/cli.CCS3MFKI.mjs 78 B 0%
shared/cli.C935N1ss.mjs 687 B 0%

Copy link

pkg-pr-new bot commented Mar 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt@781
npm i https://pkg.pr.new/@nuxt/cli@781
npm i https://pkg.pr.new/nuxi@781

commit: c716328

@danielroe
Copy link
Member

danielroe commented Mar 7, 2025

this is lovely!

CleanShot 2025-03-07 at 20 32 52@2x

I think it would be nice to display a description for each one if possible.

(We can think about a search-as-you-type module install as a second step, but this is a great start.)

@danielroe danielroe requested a review from atinux March 7, 2025 20:33
@atinux
Copy link
Member

atinux commented Mar 7, 2025

Updated to add the description + bold/green:
CleanShot 2025-03-07 at 23 30 15@2x

@DamianGlowala, you are amazing ❀️

@danielroe danielroe merged commit 6262c95 into main Mar 7, 2025
11 checks passed
@danielroe danielroe deleted the feat/interactive-modules-selector branch March 7, 2025 23:13
@github-actions github-actions bot mentioned this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

interactive modules selector after init

3 participants