Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve lighthouse score #86

Merged
merged 4 commits into from
Feb 22, 2021
Merged

chore: Improve lighthouse score #86

merged 4 commits into from
Feb 22, 2021

Conversation

farnabaz
Copy link
Collaborator

@farnabaz farnabaz commented Feb 22, 2021 •
edited
Loading

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

resolves #74
resolves #87

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link

vercel bot commented Feb 22, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxtlabs/docus/CvqBhJ34uL4s6fUPjHQtjV7HfbJy
✅ Preview: https://docus-git-lighthouse-100-nuxtlabs.vercel.app

@farnabaz farnabaz marked this pull request as draft February 22, 2021 11:13
@farnabaz farnabaz marked this pull request as ready for review February 22, 2021 12:09
atinux
atinux reviewed Feb 22, 2021
View reviewed changes
theme/nuxt.config.js Outdated Show resolved Hide resolved
@atinux atinux changed the title Improve lighthouse score chore: Improve lighthouse score Feb 22, 2021
@atinux atinux merged commit 31654a0 into main Feb 22, 2021
@atinux atinux deleted the lighthouse-100 branch February 22, 2021 14:08
Tahul added a commit that referenced this pull request Apr 20, 2022
@Tahul
feat(app): create a module from @docus/app (#86)
5ea38ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux atinux left review comments

@benjamincanac benjamincanac Awaiting requested review from benjamincanac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid empty link at menu Lighthouse score 💯
2 participants
@farnabaz @atinux