Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app container split #338

Merged
merged 25 commits into from
Jun 2, 2021
Merged

feat: app container split #338

merged 25 commits into from
Jun 2, 2021

Conversation

Tahul
Copy link
Contributor

@Tahul Tahul commented May 26, 2021

Work in progress refactor of app layouts;

  • Implement a default layout
  • Global template state
  • Handle layout from a user overridable component
  • Handle toggle of UI parts per-page (aside, navigation)
  • Remove unnecessary templates (avoiding boilerplate)
  • Still allows layout overwriting from theme
  • Allows to specify default layout from docus.config.js
  • Removes full page flickering on page change

I think this is ready for review.

Known issue:

  • On first render, AsideNavigation flickers once and then works well, would appreciate help on this.

@vercel
Copy link

vercel bot commented May 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxtlabs/docus/7KE8sgaaZtk2xc6kNRKUWR2nuQ4S
✅ Preview: https://docus-git-feat-app-container-nuxtlabs.vercel.app

@Tahul
Copy link
Contributor Author

Tahul commented Jun 1, 2021

Hey 😄; ready for review @bdrtsky @farnabaz @atinux

Copy link
Contributor

@bdrtsky bdrtsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For AppLayout.vue: I think we could wrap this slot into main tag, since it’s basically where <Nuxt/> will be rendered

Also, AppPage looks more like AppArticle, maybe rename it, since AppPage not really descriptive.

Copy link
Contributor

atinux commented Jun 2, 2021

I like the idea of wrapping with <main>.

@Tahul Tahul merged commit fc505a6 into main Jun 2, 2021
@Tahul Tahul deleted the feat/app-container branch June 2, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants