-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: app container split #338
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nuxtlabs/docus/7KE8sgaaZtk2xc6kNRKUWR2nuQ4S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For AppLayout.vue
: I think we could wrap this slot into main
tag, since it’s basically where <Nuxt/>
will be rendered
Also, AppPage
looks more like AppArticle
, maybe rename it, since AppPage
not really descriptive.
I like the idea of wrapping with |
Work in progress refactor of app layouts;
I think this is ready for review.
Known issue: