Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update nuxt-vite to 0.1.x #306

Merged
merged 1 commit into from
May 12, 2021
Merged

feat: update nuxt-vite to 0.1.x #306

merged 1 commit into from
May 12, 2021

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented May 12, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Update nuxt-vite to 0.1.x
  • SSR is disabled by default so removed internal disable code
  • (unrelated refactor) avoid destructure from nuxt or nuxt.options (hooks variable name is ambiguous)
  • Use experimentWarning to hide warning and removed patch
  • Side effect: Pinned vite to ~2.2 (pending feat: vite 2.3 nuxt/vite#138)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link

vercel bot commented May 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxtlabs/docus/HC8kkQ6acFcTsLq3fMtQmbm9if6P
✅ Preview: https://docus-git-feat-vite-upgrade-nuxtlabs.vercel.app

@Tahul
Copy link
Contributor

Tahul commented May 12, 2021

Excellent, I was working on the same thing! 😄

Thanks @pi0; I'm merging this right now!

@Tahul Tahul merged commit b44372a into main May 12, 2021
@pi0 pi0 deleted the feat/vite-upgrade branch May 12, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants