Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow changing background colors #717

Closed
Lexpeartha opened this issue Dec 8, 2022 · 3 comments · Fixed by #875
Closed

feat: allow changing background colors #717

Lexpeartha opened this issue Dec 8, 2022 · 3 comments · Fixed by #875
Assignees

Comments

@Lexpeartha
Copy link

I think it would be really useful allowing others to modify background of the website, instead of hard-coding it to color.black in the css file

There already may be a good way to do this, in which case I think it would be good to mention this in the docs

Note: I tried creating my own main.css file to override docus' styles, but that didn't work for me

@Tahul
Copy link
Contributor

Tahul commented Dec 8, 2022

Hey @Lexpeartha ; we should add that for sure!

Will do that in next release!

@Lexpeartha
Copy link
Author

If you have any suggestions on how should API/changing of background look like, drop it here - I could make a PR

Copy link
Contributor

bdrtsky commented Dec 12, 2022

@Lexpeartha thanks, I was planning to add additional related improvements for Docus tokenisation, that's why it's pending. Right now it needs to wait until Pinceau tokens.config HMR/restart issue is fixed. But if you want to make background specific update, then you can add docus.body.backgroundColor/docus.body.color tokens in tokens.config and move styles from main.css using this API

docus: {
  body: {
    backgroundColor: {
      initial: '',
      dark: ''
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants