Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve logo path #352

Closed
Tracked by #520
pi0 opened this issue May 28, 2021 · 3 comments · Fixed by #528
Closed
Tracked by #520

Resolve logo path #352

pi0 opened this issue May 28, 2021 · 3 comments · Fixed by #528
Assignees
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Contributor

pi0 commented May 28, 2021

  • Using require.resolve or ~/ path references to logo, webpack can hash filename for long term caching
  • It gives possibility to inline svg version (depends on Use svg loader and image module by default #351)
  • Ideally logo should be moved to top or assets then
@pi0 pi0 added the enhancement New feature or request label May 28, 2021
@Tahul
Copy link
Contributor

Tahul commented Jun 2, 2021

Hello @pi0 ; that is an excellent idea, thanks for the advice! 🙏

Hey @farnabaz ; could you take a look at this? 😄

Copy link
Collaborator

farnabaz commented Jun 3, 2021

I think using Nuxt Image will solve this issue. Am I right @pi0 ?

@pi0
Copy link
Contributor Author

pi0 commented Jun 3, 2021

@farnabaz Yes If you are directly using nuxt-img tag but i would suggest conditionally using $img API to generate URL and inline SVG when used. This can remove logo blink when loading page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants