Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inline SVG logo on production #528

Merged
merged 6 commits into from
Jul 1, 2021
Merged

feat: inline SVG logo on production #528

merged 6 commits into from
Jul 1, 2021

Conversation

farnabaz
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

resolves #352

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link

vercel bot commented Jun 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxtlabs/docus/8wZyyDFaFD93GiCCxsChdQr1cVmR
✅ Preview: https://docus-git-feat-inline-icons-nuxtlabs.vercel.app

@farnabaz farnabaz marked this pull request as draft June 30, 2021 16:00
@farnabaz farnabaz marked this pull request as ready for review June 30, 2021 16:10
@farnabaz
Copy link
Collaborator Author

Since we use system as a default preference for colorMode, there is an issue with inlining on first load, when system preference is not light.

This can be resolve if use css to toggle light/dark logo, but it pollute the page with huge unused html

@atinux
Copy link
Contributor

atinux commented Jun 30, 2021

I think it's fine to have double html for logo since it is in the header and we shall have a perfect UX.

What could be nice is if we can have a way to apply a different class for the SVG for our logo directly to only use one?

@farnabaz Volta.net
Copy link
Collaborator Author

By different class you mean customizable class or different class based on color?

@atinux
Copy link
Contributor

atinux commented Jun 30, 2021

Updated, I believe using a Logo.vue component is much sexier and easier to customise for light and dark modes

@atinux atinux requested review from Tahul and atinux June 30, 2021 18:31
@atinux
Copy link
Contributor

atinux commented Jun 30, 2021

I also removed @nuxtjs/svg as I think it is not necessary for the logo, by documenting how to use a SVG logo by using a component, it will be much more powerful

@Tahul
Copy link
Contributor

Tahul commented Jul 1, 2021

Excellent changes; thanks @farnabaz & @atinux 😄

@Tahul Tahul merged commit 9623495 into dev Jul 1, 2021
@Tahul Tahul deleted the feat/inline-icons branch July 1, 2021 08:37
Tahul added a commit that referenced this pull request Jul 12, 2021
@Tahul @farnabaz
@bdrtsky @atinux @antfu
chore: release 0.9.0 (#543)
0567c4b 
* 📝 (docs) update docs; add algolia docsearch in configuration

* fix(layout): fix parents order in layout inheritance

* fix: add fixed width to mobile aside (#515)

* fix: multiple regressions (#516)

* fix: margins for docs content

* fix: multiple issues

* feat: enhanced i18n (#517)

* fix(Link): support locale path & improve attrs

* fix(contentLocalePath): handle locale prefix

* 🐛 (link) fix blank reeference (props.blank)

* 🔖 (0.8.6) release 0.8.6

* 🐛 (prose-code-inline) allow line break (#519)

* fix: scrollspy & scroll to top on click for Releases (#522)

* fix: restrict inline syntax (#526)

* fix: restrict inline syntax

* fix: allow inline syntax inside span & links

* feat: auto collapse when click on another section (#527)

* init pr

* ✨ (aside) restore collapse state on section toggle

Co-authored-by: Yaël GUILLOUX <yael.guilloux@gmail.com>

* 🐛 (nuxtjs.org) small responsive/sizing fixes

* fix: prose nested lists (#529)

* fix: prose nested lists

* cleanup

* fix: multiple style issues (#523)

* fix: code block issues

* update filename shortcut

* feat: support slot to show between children (#525)

* feat: support slot to show between children

* fix: do not add `between` slot between inline nodes

* feat: inline SVG logo on production (#528)

* feat: inline svg icon on production

* fix: import

* chore: cleanup

* feat: improve logo management, add default Logo component and shortcuts

* chore: remove @nuxtjs/svg

* chore: simplify markup

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>

* feat: SandBox Component (#518)

* feat: SandBox Component

* chore: minor fix

* feat: init Tabs component; refactor CodeGroup

* update Sandbox UI

Co-authored-by: Sergey Bedritsky <sergey.bedritsky@gmail.com>

* 📦 (deps) upgrade dependencies

* 🐛 (aside) fix aside navigation collapsing

* 🐛 (aside) fix social icons spacing at the right place

* 🔖 (0.8.7) release 0.8.7

* 📦 (deps) upgrade deps (nuxt-image)

* 🐛 (sandbox) fix sandbox component

* feat: add custom scrollbar (#534)

* fix: update mobile toc overflow from scroll to auto (#532)

* 🔖 (0.8.8) release 0.8.8

* 📝 (deployment) update deployment to add npm cache

* 🔖 (0.8.9) release 0.8.9

* 🐛 (aside) hover color only in large on aside nav item

* init AppBanner (#536)

* init AppBanner

* ✨ (banner) edit defaults

* 📝 (config) update configuration with banner arg

Co-authored-by: Yaël GUILLOUX <yael.guilloux@gmail.com>

* 🔖 (0.8.10) release 0.8.10

* 🔖 (0.8.11) release 0.8.11

* 🐛 (docs) update docs links (avoid errors while building..)

* fix: Releases content overflow (#537)

* fix: Releases content overflow

* 🐛 (releases) only apply overflow-x-hidden

Co-authored-by: Yaël GUILLOUX <yael.guilloux@gmail.com>

* 🐛 (content) fix content links avoiding a longer build

* 🔖 (0.8.12) release 0.8.12

* chore: reduce UX issues (lazy loading and jump)

* fix: currentNav updated after page change

Also disabled smart prefetch for lazy components in the meantime

* chore: add isAsync too

* fix: revert back to old collapse logic (#539)

* ⏪ (collapse) revert back to old collapse logic

* 🐛 (navigation) preserve uncollapsing for first visited category

* 📌 (deps) pin vue to 2.6.14

* 🐛 (twitter) fix twitter component import

* fix: set variables on SSR from asyncData

* 🔖 (0.8.13) release 0.8.13

* 🔖 (0.8.14) release 0.8.14

* fix: resolve flash issue using render fucntion instead of template (#541)

* feat: Docus loading screen

* 🔖 (0.8.15) release 0.8.15

* fix: tokenise blogpost (#540)

* feat: change slot definition (#535)

* feat: change slot definition

* feat: front matter style data

* chore: update docs

* docs: fix docs

* chore: refactor data tokenizer

* fix: typo

* fix: invalid line detection

* feat: use remark-github (#538)

* feat(admin): admin improvements (#524)

* wip: components playground

* fix: switch to nuxt module for components preview

* refactor(admin): modulize preview

* refactor(admin): folder structure

* chore: typo

* feat(admin): embed windicss-analysis

* chore: update notes

* feat: config tab

* feat: preview navigate to editor

* fix(admin): reuse utils instance for windi analysis

* chore: update deps

* feat(admin): entry for  windi analyzer

* chore: clean up

* Apply suggestions from code review

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>

* 🚨 (lint) no-console fix

* chore: cleanup vite fix

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Yaël GUILLOUX <yael.guilloux@gmail.com>

Co-authored-by: Ahad Birang <farnabaz@gmail.com>
Co-authored-by: Sergey Bedritsky <sergey.bedritsky@gmail.com>
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux atinux approved these changes

@Tahul Tahul Awaiting requested review from Tahul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve logo path
3 participants
@farnabaz @atinux @Tahul