-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send perspective as query param when using GET method #1008
Conversation
✅ Deploy Preview for nuxt-sanity-module canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just move the query up into fetchOptions?
Hah, good point! Completely missed that 😅 Changed now |
Noticed the RequestInit type doesn't allow for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually ... Maybe we need to add it to the qs
as &perspective=
rather than via query
for the get
request... Seems like it would produce a double query otherwise.
When I tested it just appended perspective to the existing query params and worked as expected. But I can double check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ❤️
This is the same issue as here: #930 but with GET queries. This appends perspective there as well.