Skip to content

docs(playground): minor clean up in the playground's tabs #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2022
Merged

docs(playground): minor clean up in the playground's tabs #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f17173e
clean up unused import & class in tab1
azrikahar Aug 31, 2022
798f0d8
align tab4 title to "Animation examples"
azrikahar Aug 31, 2022
6b277f5
clean up tab2
azrikahar Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions playground/pages/tabs/tab1.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<script setup lang="ts">
import { add } from 'ionicons/icons'

definePageMeta({
alias: ['/', '/tabs'],
})
Expand All @@ -9,7 +7,7 @@ definePageMeta({
<template>
<ion-page>
<ion-header translucent>
<ion-toolbar class="toolbar">
<ion-toolbar>
<ion-thumbnail slot="start">
<ion-img src="/icon.png" />
</ion-thumbnail>
Expand Down
15 changes: 6 additions & 9 deletions playground/pages/tabs/tab2.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script setup lang="ts">
import { actionSheetController } from '@ionic/vue'
import { camera, trash, close } from 'ionicons/icons'
import { UserPhoto } from '@/composables/usePhotoGallery'
const { photos, takePhoto, deletePhoto } = usePhotoGallery()

const showActionSheet = async (photo: UserPhoto) => {
Expand All @@ -10,14 +10,14 @@ const showActionSheet = async (photo: UserPhoto) => {
{
text: 'Delete',
role: 'destructive',
icon: trash,
icon: ioniconsTrash,
handler: () => {
deletePhoto(photo)
},
},
{
text: 'Cancel',
icon: close,
icon: ioniconsClose,
role: 'cancel',
handler: () => {
// Nothing to do, action sheet is automatically closed
Expand All @@ -44,18 +44,15 @@ const showActionSheet = async (photo: UserPhoto) => {
</ion-header>
<ion-grid>
<ion-row>
<ion-col size="6" :key="photo" v-for="photo in photos">
<ion-img
:src="photo.webviewPath"
@click="showActionSheet(photo)"
></ion-img>
<ion-col size="6" :key="photo.filepath" v-for="photo in photos">
<ion-img :src="photo.webviewPath" @click="showActionSheet(photo)"></ion-img>
</ion-col>
</ion-row>
</ion-grid>

<ion-fab vertical="bottom" horizontal="center" slot="fixed">
<ion-fab-button @click="takePhoto()">
<ion-icon :icon="camera"></ion-icon>
<ion-icon :icon="ioniconsCamera"></ion-icon>
</ion-fab-button>
</ion-fab>
</ion-content>
Expand Down
4 changes: 2 additions & 2 deletions playground/pages/tabs/tab4.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
<ion-page>
<ion-header>
<ion-toolbar>
<ion-title>Tab 3</ion-title>
<ion-title>Animation examples</ion-title>
</ion-toolbar>
</ion-header>
<ion-content :fullscreen="true">
<ion-header collapse="condense">
<ion-toolbar>
<ion-title size="large">Tab 3</ion-title>
<ion-title size="large">Animation examples</ion-title>
</ion-toolbar>
</ion-header>

Expand Down