Skip to content

Conversation

@johannschopplich
Copy link

@johannschopplich johannschopplich commented Oct 4, 2023

I'm not sure what causes the issue, but disabling payload extraction is required for the generated SSG build to work properly.

With the payload extraction enabled by default, the error described in #460 will occur.

This feels like a workaround and I'm sure there's a better solution out there. I just don't know what to look for. Any help would be appreciated.

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for friendly-lamington-fb5690 canceled.

Name Link
🔨 Latest commit 664bb08
🔍 Latest deploy log https://app.netlify.com/sites/friendly-lamington-fb5690/deploys/651d25e9a9f1e60008d2d38f

@harlan-zw
Copy link

Probably worth adding in a warning message if it's enabled and it's being disabled, just so the end user knows what's going on.

That's to say, if we can't fix the underlying issue and need to rely on this.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@88895ac). Click here to learn what that means.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage        ?   83.06%           
=======================================
  Files           ?        9           
  Lines           ?      496           
  Branches        ?       30           
=======================================
  Hits            ?      412           
  Misses          ?       84           
  Partials        ?        0           
Files Coverage Δ
src/module.ts 73.79% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@danielroe danielroe closed this in b35c642 Jan 9, 2024
sphinxDevVic added a commit to sphinxDevVic/ionic that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants