fix: don't add trailing slashes to generated routes #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module was adding a trailing slash for extra routes that it was generating. This isn't normally a problem as VueRouter runs by default in non-strict mode and normalizes paths to not have trailing slashes but when the "router.trailingSlash = false" option was set in Nuxt, then the matching was strict and actually made trailing slashes appear in the path. Follow the same logic as Nuxt and: - don't add trailing slashes by default or when "router.trailingSlash" option is set to "false" - add trailing slashes when "router.trailingSlash" option is set to "true" Resolves #717
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
==========================================
+ Coverage 97.60% 97.67% +0.07%
==========================================
Files 3 3
Lines 125 129 +4
Branches 33 35 +2
==========================================
+ Hits 122 126 +4
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module was adding a trailing slash for extra routes that
it was generating.
This isn't normally a problem as VueRouter runs by default in
non-strict mode and normalizes paths to not have trailing slashes but
when the "router.trailingSlash = false" option was set in Nuxt, then
the matching was strict and actually made trailing slashes appear in
the path.
Follow the same logic as Nuxt and:
option is set to "false"
to "true"
Resolves #717