fix: type pollution through shared-imports.d#3923
Merged
BobbieGoede merged 1 commit intonuxt-modules:mainfrom Feb 4, 2026
Merged
fix: type pollution through shared-imports.d#3923BobbieGoede merged 1 commit intonuxt-modules:mainfrom
shared-imports.d#3923BobbieGoede merged 1 commit intonuxt-modules:mainfrom
Conversation
shared-imports.dshared-imports.d
commit: |
Contributor
WalkthroughThis pull request updates type definitions in the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
The types added to tsconfig need to be reworked in this module, and it would be good to rework the composable exports to prevent accidentally importing things that are not available in certain contexts (shared/nuxt/nitro).
Typecheck fails in Nuxt 4.3.0 due to the following (used as type only)
import { useHead } from '#imports';, this was not an issue in previous releases. This might be something more modules will run into /cc @danielroe - related to nuxt/nuxt#34142.Summary by CodeRabbit
Release Notes