perf: favor importing generated options over passing as argument #2714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Instead of passing the generated
nuxtI18nOptions
as arguments, I instead importnuxtI18nOptions
when needed or only pass the relevant properties instead of the full object.Since most of the memory leaks so far have been related to the generated options, and we probably shouldn't mutate the generated options, this may reduce memory usage and reduce the odds of keeping a reference to the entire object in a closure. Maybe we could consider freezing the generated options to prevent any mutations, something to look into another time.
π Checklist