chore: migrate to ESLint flat config #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- `root: true` is not needed in flat config
kazupon
approved these changes
Dec 16, 2023
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
* chore: migrate globals -- `root: true` is not needed in flat config * chore: migrate extends * chore: migrate TS plugin * chore: migrate TS parser * chore: remove eslintrc * chore: migrate eslint.ignore * chore: migrate files extensions * fix: move globals & parserOptions to languageOptions * fix: use `FlatCompat` utility to extend plugins correctly * fix: move ignores to top * fix: remove deprecated `--ext` flag from commands * chore: format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#2607
❓ Type of change
📚 Description
This migrates the repo to use the new ESLint Flat Config which is the default starting from v9.
My testing to see if this works is basically running the
lintcommand and expecting the same output.Remarks:
envis deprecated in Flat config, usingglobalsis the (recommended way)[https://eslint.org/docs/latest/use/configure/migration-guide#configuring-language-options]Used the official
FlatCompatutility to migratets-plugin(as recommended by this comment)[https://github.com/ESLint Flat Config Support typescript-eslint/typescript-eslint#7694#issuecomment-1854655034]. When it's officially migrated, it'll be a simple replace.I've added comments on top of each section but this isn't necessary as you can mix anything in flat configs. I've used them to clarify the steps only. Feel free to remove them.
📝 Checklist