-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support server-side i18n integration #2558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is still WIP. |
kazupon
changed the title
feat: support server-side i18n integration
WIP: feat: support server-side i18n integration
Nov 16, 2023
BobbieGoede
reviewed
Nov 25, 2023
This was referenced Nov 27, 2023
* fix: server integration layer support * test: test `localeDetector` usage
β Live Preview ready!
|
BobbieGoede
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it looks great!
Only some small fixes/changes for the docs, other than that it looks like it can be merged πͺ
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
@BobbieGoede |
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This PR is feature PR of
@intlify/h3
integration for nuxt i18n, and experimental feature.I will also add docs.
we will consider some stuff the following:
defineI18nMiddleware
in the initialization of the nitro pluginexperimental.localeDetector
option in the nuxt i18n config.π Checklist