Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: disable addDirAttribute by default #1239

Merged
merged 1 commit into from
Jul 20, 2021
Merged

refactor!: disable addDirAttribute by default #1239

merged 1 commit into from
Jul 20, 2021

Conversation

divine
Copy link

@divine divine commented Jul 20, 2021

No description provided.

@rchl
Copy link
Collaborator

rchl commented Jul 20, 2021

Please also note it in the migration docs.

@divine divine force-pushed the disable-addDirAttribute branch from a87bdf9 to e5621f9 Compare July 20, 2021 09:07
@rchl
Copy link
Collaborator

rchl commented Jul 20, 2021

Also found this place that needs updating: https://github.com/nuxt-community/i18n-module/blob/ffeaa7e41d025329a41f6c387010d9c3806db762/types/vue.d.ts#L17-L21

@rchl
Copy link
Collaborator

rchl commented Jul 20, 2021

BTW. We can use the jsdoc @default tag in the comment.

  /**
   * Adds a `dir` attribute to the HTML element.
   * @default false
   */
  addDirAttribute?: boolean

@divine
Copy link
Author

divine commented Jul 20, 2021

BTW. We can use the jsdoc @default tag in the comment.

  /**
   * Adds a `dir` attribute to the HTML element.
   * @default false
   */
  addDirAttribute?: boolean

Update the other one as well?

https://github.com/nuxt-community/i18n-module/blob/ffeaa7e41d025329a41f6c387010d9c3806db762/types/vue.d.ts#L22-L26

@rchl
Copy link
Collaborator

rchl commented Jul 20, 2021

Yes please.

@divine divine force-pushed the disable-addDirAttribute branch from e5621f9 to c15a688 Compare July 20, 2021 12:40
@rchl rchl merged commit 47787df into nuxt-modules:next Jul 20, 2021
@rchl
Copy link
Collaborator

rchl commented Jul 20, 2021

Thanks!

@divine divine deleted the disable-addDirAttribute branch July 20, 2021 13:37
rchl pushed a commit that referenced this pull request Jul 22, 2021
@divine @rchl
refactor!: disable addDirAttribute by default (#1239)
e55b418
@rchl rchl mentioned this pull request Jul 29, 2021
Closed
10 tasks
rchl pushed a commit that referenced this pull request Aug 3, 2021
@divine @rchl
refactor!: disable addDirAttribute by default (#1239)
6a344dd
rchl pushed a commit that referenced this pull request Aug 3, 2021
@divine @rchl
refactor!: disable addDirAttribute by default (#1239)
eac6130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchl rchl rchl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divine @rchl