fix: don't skip the cookie if no locale is detected in the route

[strebl]

That PR fixes #1234.

It uses the cookie locale, if no locale is set yet.

[rchl]

One thing I would also need is a test that reproduces the issue fixed here. Should probably be added in test/browser.test.js.

[rchl]

I can't push to your branch since you haven't checked the relevant checkbox but here is the test:

describe(`${browserString} (onlyOnNoPrefix + prefix)`, () => {
  /** @type {Nuxt} */
  let nuxt
  /** @type {import('playwright-chromium').ChromiumBrowser} */
  let browser

  beforeAll(async () => {
    const overrides = {
      i18n: {
        defaultLocale: 'en',
        strategy: 'prefix',
        detectBrowserLanguage: {
          onlyOnNoPrefix: true
        }
      }
    }

    nuxt = (await setup(loadConfig(__dirname, 'basic', overrides, { merge: true }))).nuxt
    browser = await createBrowser()
  })

  afterAll(async () => {
    if (browser) {
      await browser.close()
    }
    await nuxt.close()
  })

  test('uses saved locale cookie when redirecting from root', async () => {
    const page = await browser.newPage({ locale: 'fr' })
    // Ensure the detected locale cookie is saved
    await page.goto(url('/fr'))
    expect(await (await page.$('body'))?.textContent()).toContain('locale: fr')
    expect(await getRouteFullPath(page)).toBe('/fr')
    // Verify that we navigate to saved locale
    await page.goto(url('/'))
    expect(await (await page.$('body'))?.textContent()).toContain('locale: fr')
    expect(await getRouteFullPath(page)).toBe('/fr')
  })
})

[strebl]

Thank you very much @rchl

I don't see the checkbox mentioned in the github docs.

However I've added your test 👍🏻 All tests are green 🎉 I see some multiple errors tho: Error generating route "/about-us": This page could not be found.

[rchl]

Thanks!