refactor!: replace onlyOnNoPrefix and onlyOnRoot with redirectOn

[divine]

Trying to make this PR sensible because enabling detectBrowserLanguage.onlyOnRoot here by default creates a lot of failing tests thus making this PR huge.

[rchl]

Aren't we losing support for a certain behavior now?

Previously there were three options (if we assume alwaysRedirect is false):

• default behavior - redirect on all URLs
• onlyOnRoot - redirect only from root
• onlyOnNoPrefix - redirect only when no prefix

Now the onlyOnRoot options combines the two last cases.

Even if I said to "combine" those two options, I didn't mean to combine the behavior but combine those two separate options into one option that the user can use to selectively enable each behavior. So something like redirectOn: 'root' | 'no-prefix' (not entirely convinced on the naming here but you get the idea).

[divine]

So something like redirectOn: 'root' | 'no-prefix'

Hello,

I still think that we should merge both options ( 'root' | 'no-prefix') into one because it's indeed a bug fix or add another lax option which will combine two of them into one as well.

@dword-design you've worked on adding that feature, what do you think?

Thanks!

[rchl]

I still think that we should merge both options ( 'root' | 'no-prefix') into one because it's indeed a bug fix or add another lax option which will combine two of them into one as well.

I was under impression that no-prefix (old name onlyOnNoPrefix) is worse for SEO since it might result in crawler being redirected from path like /foo to en/foo while with root (onlyOnRoot) the issue would only exist for the root path.

Here is current description of the options:

• onlyOnRoot (default: false) - Set to true (recommended for improved SEO) to only attempt to detect the browser locale on the root path (/) of the site. Only effective when using strategy other than 'no_prefix'.
• onlyOnNoPrefix (default: false) - This is a more permissive variant of onlyOnRoot that will attempt to detect the browser locale on the root path (/) and also on paths that have no locale prefix (like /foo). Only effective when onlyOnRoot is not enabled and using strategy other than 'no_prefix'.

[dword-design]

@divine Hey, not sure where I am helpful here, sounds more like an architectural issue 😄. But I will help if needed.

Merging currently does not make sense to me because root means it should only redirect on root and nothing else, while no-prefix redirects on all routes without a prefix (possibly including root). Which is distinctive behavior.

Which of both you think is a bugfix?

[divine]

Sorry guys, I misunderstood that issue!

@rchl let me know if anything else is needed.

Thanks!

[rchl]

There are still 2 references to onlyOnRoot in documentation.

[rchl]

There are still 2 references to onlyOnRoot in documentation.

Actually that's in the SEO page so should merge next before updating those.

[rchl]

There are still 2 references to onlyOnRoot in documentation.

Actually that's in the SEO page so should merge next before updating those.

No, sorry, it's actually the browser-language-detection.md file that still references onlyOnRoot.

[rchl]

Thanks!