fix(differentDomains): handling of runtime domains from store #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen differentDomains is true
…cales before extending the vue instance so app.i18n can get the store domains in the locale array and localProperties object. Fix getLocaleDomain not finding the correct domain when using differentDomains
|
Sorry for the delay. I'll try to understand and review it soon. For now have only one initial thought that it's likely not safe to assume that runtime configuration is supported by this module. Thus making some cases handle runtime configuration is still not likely gonna be flawless. |
rchl
reviewed
Jun 22, 2021
Closed
|
✔️ Deploy Preview for nuxt-i18n canceled. 🔨 Explore the source changes: 8a50da7 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt-i18n/deploys/61143c08b0da150007cac4cc |
rchl
changed the title
|
Thanks. Sorry for a very long wait. |
|
No worries at all! Happy to take the discussion further if you want to improve the solution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following documentation https://i18n.nuxtjs.org/different-domains/#runtime-environment-variables. Configuring nuxt-i18n using
differentDomains: trueand defining the domains only in the store using with runtime environment variables end up with the warningCould not find domain name for locale xx.The issue is that domain matching is made using
options.normalizedLocaleswhich is not updated with the domains from the store: https://github.com/nuxt-community/i18n-module/blob/master/src/templates/plugin.main.js#L370-L375.This PR aims to update
options.localesinstead ofapp.i18n.localessince it is based on it, and updateoptions.normalizedLocalessoapp.i18n.localePropertiescontains thedomainproperty andgetLocaleDomainmethod can match a provided domain.It also update the
onNavigatemethod so we don't try to get the locale from the route when using differentDomains since the route wont contain the proper locale.