fix(kv,cache): merge default binding when driver explicitly set #767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766
Problem
When explicitly setting
driver: 'cloudflare-kv-binding'in hub.kv/cache config,resolveKVConfig()andresolveCacheConfig()return early without merging the default binding. This causes unstorage to fall back to'STORAGE'binding which doesn't exist.Solution
Merge default binding (
'KV'for kv,'CACHE'for cache) when driver is explicitly set tocloudflare-kv-binding.Reproduce bug
Shows
driver({})- empty options.Verify fix
Shows
driver({"binding":"KV"}).Test?
Let me know if we should include tests to avoid future regressions